Page MenuHomeSoftware Heritage

Simplify priority computation in tests + improve exhaustivity
ClosedPublic

Authored by vlorentz on Apr 20 2021, 11:47 AM.

Details

Summary

We no longer need to deal with ratios, so let's count the objects
directly instead.

Plus, the existing tests did not check tasks with None priority
(because they did not have access to it when ratios were given
by the backend), so they do now.

Depends on D5552.
Related to T3271

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 20 2021, 11:47 AM
Harbormaster failed remote builds in B20871: Diff 19862!

Build is green

Patch application report for D5561 (id=19863)

Rebasing onto befccb94d6...

Current branch diff-target is up to date.
Changes applied before test
commit 26d3e5e9e71329b31fda404b3200737cae9d92c4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Apr 20 11:46:53 2021 +0200

    Simplify priority computation in tests + improve exhaustivity
    
    We no longer need to deal with ratios, so let's count the objects
    directly instead.
    
    Plus, the existing tests did not check tasks with None priority
    (because they did not have access to it when ratios were given
    by the backend), so they do now.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/332/ for more details.

This revision is now accepted and ready to land.Apr 20 2021, 12:56 PM
This revision was landed with ongoing or failed builds.Apr 20 2021, 1:01 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D5561 (id=19867)

Rebasing onto f33f74346f...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-333-D5561.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/333/ for more details.