Page MenuHomeSoftware Heritage

scheduler: Clean up priority/ratio task dead code
ClosedPublic

Authored by ardumont on Mon, Apr 19, 12:36 PM.

Details

Summary

Since [1], tasks with priority are routed to dedicated queues (see tasks for more
details). The tasks with priority to be scheduled have their own dedicated endpoints to
be called.

[1] Related to T3084

Related to T3271

Test Plan

tox

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.

Adapt commit message according to the diff description

Build is green

Patch application report for D5552 (id=19825)

Rebasing onto 974c0c2e05...

Current branch diff-target is up to date.
Changes applied before test
commit 4888b3aa2b71e0ef6f0205139c4ef639c7329c69
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Apr 19 12:26:58 2021 +0200

    scheduler: Clean up priority/ratio task dead code
    
    Related to T3271

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/323/ for more details.

Build is green

Patch application report for D5552 (id=19826)

Rebasing onto 974c0c2e05...

Current branch diff-target is up to date.
Changes applied before test
commit a5bee8960741b66d69af7a3b19dc2d036e330b15
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Apr 19 12:26:58 2021 +0200

    scheduler: Clean up priority/ratio task dead code
    
    Since [1], tasks with priority are routed to dedicated queues (see tasks for more
    details). The tasks with priority to be scheduled have their own dedicated endpoints to
    be called.
    
    [1] Related to T3084
    Related to T3271

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/324/ for more details.

Build is green

Patch application report for D5552 (id=19827)

Rebasing onto 974c0c2e05...

Current branch diff-target is up to date.
Changes applied before test
commit f3e08094ac90c1e39e596dfe67314701fc93a711
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Apr 19 12:26:58 2021 +0200

    scheduler: Clean up priority/ratio task dead code
    
    Since [1], tasks with priority are routed to dedicated queues (see tasks for more
    details). The tasks with priority to be scheduled have their own dedicated endpoints to
    be called.
    
    [1] Related to T3084
    Related to T3271

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/325/ for more details.

Build is green

Patch application report for D5552 (id=19828)

Rebasing onto 974c0c2e05...

Current branch diff-target is up to date.
Changes applied before test
commit aafd88c251d07df55406c9e8d12e7323348263f1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Apr 19 12:26:58 2021 +0200

    scheduler: Clean up priority/ratio task dead code
    
    Since [1], tasks with priority are routed to dedicated queues (see tasks for more
    details). The tasks with priority to be scheduled have their own dedicated endpoints to
    be called.
    
    [1] Related to T3084
    Related to T3271

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/326/ for more details.

vlorentz added inline comments.
swh/scheduler/tests/test_scheduler.py
33

existing

and what test code is it? why isn't it updated too?

swh/scheduler/tests/test_scheduler.py
33

it is updated. Check below.

The code that creates tasks (with and without priority) or the ones that read tasks (the ones read tasks with no priority check that they don't have any priority).

Build is green

Patch application report for D5552 (id=19829)

Rebasing onto 974c0c2e05...

Current branch diff-target is up to date.
Changes applied before test
commit 9d4fd55a98f709846b056a5388a479a4a07538c2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Apr 19 12:26:58 2021 +0200

    scheduler: Clean up priority/ratio task dead code
    
    Since [1], tasks with priority are routed to dedicated queues (see tasks for more
    details). The tasks with priority to be scheduled have their own dedicated endpoints to
    be called.
    
    [1] Related to T3084
    Related to T3271

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/327/ for more details.

ardumont added inline comments.
swh/scheduler/tests/test_scheduler.py
33

existing

thx, fixed.

This revision is now accepted and ready to land.Tue, Apr 20, 11:22 AM

Build is green

Patch application report for D5552 (id=19860)

Rebasing onto 4e06bcd71e...

Current branch diff-target is up to date.
Changes applied before test
commit befccb94d60892eb380595fbdfdce0b7432a8dab
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Apr 19 12:26:58 2021 +0200

    scheduler: Clean up priority/ratio task dead code
    
    Since [1], tasks with priority are routed to dedicated queues (see tasks for more
    details). The tasks with priority to be scheduled have their own dedicated endpoints to
    be called.
    
    [1] Related to T3084
    Related to T3271

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/330/ for more details.