Page MenuHomeSoftware Heritage
Differential D5552

scheduler: Clean up priority/ratio task dead code
ClosedPublic
Actions

Authored by ardumont on Apr 19 2021, 12:36 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T3084: Fast track save code now requests
T3271: scheduler: Clean up dead code about priority/ratio
Commits
rDSCHbefccb94d608: scheduler: Clean up priority/ratio task dead code
Summary

Since [1], tasks with priority are routed to dedicated queues (see tasks for more
details). The tasks with priority to be scheduled have their own dedicated endpoints to
be called.

[1] Related to T3084

Related to T3271

Test Plan

tox

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont updated this revision to Diff 19826.EditedApr 19 2021, 12:36 PM
ardumont created this revision.

Adapt commit message according to the diff description

swh-public-ci added a comment.Apr 19 2021, 12:38 PM

Build is green

Patch application report for D5552 (id=19825)

Rebasing onto 974c0c2e05...

Current branch diff-target is up to date.
Changes applied before test
commit 4888b3aa2b71e0ef6f0205139c4ef639c7329c69
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Apr 19 12:26:58 2021 +0200

    scheduler: Clean up priority/ratio task dead code
    
    Related to T3271

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/323/ for more details.

Harbormaster completed remote builds in B20834: Diff 19825.Apr 19 2021, 12:38 PM
ardumont updated this revision to Diff 19827.Apr 19 2021, 12:40 PM

Fix typo

swh-public-ci added a comment.Apr 19 2021, 12:41 PM

Build is green

Patch application report for D5552 (id=19826)

Rebasing onto 974c0c2e05...

Current branch diff-target is up to date.
Changes applied before test
commit a5bee8960741b66d69af7a3b19dc2d036e330b15
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Apr 19 12:26:58 2021 +0200

    scheduler: Clean up priority/ratio task dead code
    
    Since [1], tasks with priority are routed to dedicated queues (see tasks for more
    details). The tasks with priority to be scheduled have their own dedicated endpoints to
    be called.
    
    [1] Related to T3084
    Related to T3271

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/324/ for more details.

Harbormaster completed remote builds in B20835: Diff 19826.Apr 19 2021, 12:41 PM
swh-public-ci added a comment.Apr 19 2021, 12:43 PM

Build is green

Patch application report for D5552 (id=19827)

Rebasing onto 974c0c2e05...

Current branch diff-target is up to date.
Changes applied before test
commit f3e08094ac90c1e39e596dfe67314701fc93a711
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Apr 19 12:26:58 2021 +0200

    scheduler: Clean up priority/ratio task dead code
    
    Since [1], tasks with priority are routed to dedicated queues (see tasks for more
    details). The tasks with priority to be scheduled have their own dedicated endpoints to
    be called.
    
    [1] Related to T3084
    Related to T3271

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/325/ for more details.

Harbormaster completed remote builds in B20836: Diff 19827.Apr 19 2021, 12:43 PM
ardumont requested review of this revision.Apr 19 2021, 12:43 PM
ardumont updated this revision to Diff 19828.Apr 19 2021, 12:46 PM

Fix typos again

swh-public-ci added a comment.Apr 19 2021, 12:48 PM

Build is green

Patch application report for D5552 (id=19828)

Rebasing onto 974c0c2e05...

Current branch diff-target is up to date.
Changes applied before test
commit aafd88c251d07df55406c9e8d12e7323348263f1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Apr 19 12:26:58 2021 +0200

    scheduler: Clean up priority/ratio task dead code
    
    Since [1], tasks with priority are routed to dedicated queues (see tasks for more
    details). The tasks with priority to be scheduled have their own dedicated endpoints to
    be called.
    
    [1] Related to T3084
    Related to T3271

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/326/ for more details.

Harbormaster completed remote builds in B20837: Diff 19828.Apr 19 2021, 12:48 PM
vlorentz added a subscriber: vlorentz.Apr 19 2021, 1:52 PM
vlorentz added inline comments.
swh/scheduler/tests/test_scheduler.py
33

existing

and what test code is it? why isn't it updated too?

ardumont added inline comments.Apr 19 2021, 1:56 PM
swh/scheduler/tests/test_scheduler.py
33

it is updated. Check below.

The code that creates tasks (with and without priority) or the ones that read tasks (the ones read tasks with no priority check that they don't have any priority).

ardumont updated this revision to Diff 19829.Apr 19 2021, 1:57 PM

Fix typo

swh-public-ci added a comment.Apr 19 2021, 2:00 PM

Build is green

Patch application report for D5552 (id=19829)

Rebasing onto 974c0c2e05...

Current branch diff-target is up to date.
Changes applied before test
commit 9d4fd55a98f709846b056a5388a479a4a07538c2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Apr 19 12:26:58 2021 +0200

    scheduler: Clean up priority/ratio task dead code
    
    Since [1], tasks with priority are routed to dedicated queues (see tasks for more
    details). The tasks with priority to be scheduled have their own dedicated endpoints to
    be called.
    
    [1] Related to T3084
    Related to T3271

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/327/ for more details.

Harbormaster completed remote builds in B20838: Diff 19829.Apr 19 2021, 2:00 PM
ardumont marked an inline comment as done.Apr 19 2021, 2:40 PM
ardumont added inline comments.
swh/scheduler/tests/test_scheduler.py
33

existing

thx, fixed.

ardumont added a comment.Apr 19 2021, 6:05 PM

@vlorentz ping?

vlorentz accepted this revision.Apr 20 2021, 11:22 AM
This revision is now accepted and ready to land.Apr 20 2021, 11:22 AM
ardumont updated this revision to Diff 19860.Apr 20 2021, 11:27 AM

Rebase

swh-public-ci added a comment.Apr 20 2021, 11:30 AM

Build is green

Patch application report for D5552 (id=19860)

Rebasing onto 4e06bcd71e...

Current branch diff-target is up to date.
Changes applied before test
commit befccb94d60892eb380595fbdfdce0b7432a8dab
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Apr 19 12:26:58 2021 +0200

    scheduler: Clean up priority/ratio task dead code
    
    Since [1], tasks with priority are routed to dedicated queues (see tasks for more
    details). The tasks with priority to be scheduled have their own dedicated endpoints to
    be called.
    
    [1] Related to T3084
    Related to T3271

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/330/ for more details.

Harbormaster completed remote builds in B20869: Diff 19860.Apr 20 2021, 11:30 AM
Closed by commit rDSCHbefccb94d608: scheduler: Clean up priority/ratio task dead code (authored by ardumont). · Explain WhyApr 20 2021, 11:45 AM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDSCHbefccb94d608: scheduler: Clean up priority/ratio task dead code.
vlorentz added a child revision: D5561: Simplify priority computation in tests + improve exhaustivity.Apr 20 2021, 11:47 AM

Revision Contents
Changeset List

PathSize
sql/
updates/
29 lines
swh/
scheduler/
22 lines
61 lines
celery_backend/
2 lines
cli/
15 lines
42 lines
sql/
2 lines
96 lines
tests/
1 line
82 lines

Diff 19861

View Options

sql/updates/27.sql

Loading...
View Options

swh/scheduler/__init__.py

Loading...
View Options

swh/scheduler/backend.py

Loading...
View Options

swh/scheduler/celery_backend/runner.py

Loading...
View Options

swh/scheduler/cli/task.py

Loading...
View Options

swh/scheduler/interface.py

Loading...
View Options

swh/scheduler/sql/30-schema.sql

Loading...
View Options

swh/scheduler/sql/40-func.sql

Loading...
View Options

swh/scheduler/tests/test_api_client.py

Loading...
View Options

swh/scheduler/tests/test_scheduler.py

Loading...
About · Developer information · Legal