Warn when using db_transaction/db_transaction_generator where you shouldn't.
ClosedPublic
Actions

Authored by vlorentz on Oct 22 2018, 9:27 AM.

Details

Reviewers

Group Reviewers

Commits

rDSTOCa8fbce58f135: Warn when using db_transaction/db_transaction_generator where you shouldn't.
R65:a8fbce58f135: Warn when using db_transaction/db_transaction_generator where you shouldn't.
rDSTOa8fbce58f135: Warn when using db_transaction/db_transaction_generator where you shouldn't.

Summary

I did it, it caused closed cursors that hang the process,
that's hard to debug.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 22 2018, 9:27 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 22 2018, 9:27 AM

Harbormaster failed remote builds in B1709: Diff 1711!Oct 22 2018, 9:28 AM

lgtm.

Tested and worked as entertained:

# patch the storage locally
arc patch D556
make test
# all is green

# open swh.storage.storage.py
# replace @db_transaction_generator from content_get_metadata (randomly chosen as the first one with such decorator ;)
make test
# This fails with the error mentioned for content_get_metadata (
# revert the modification

# change content_update to @db_transaction (`use db_transaction_generator for generator function`).
make test

# This fails on content_update with the error mentioned (`use db_transaction for non-generator function`)

Thanks.

This revision is now accepted and ready to land.Oct 22 2018, 10:22 AM

Closed by commit rDSTOa8fbce58f135: Warn when using db_transaction/db_transaction_generator where you shouldn't. (authored by vlorentz). · Explain WhyOct 22 2018, 11:03 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

storage/

common.py

9 lines

Diff 1714

View Options

Warn when using db_transaction/db_transaction_generator where you shouldn't.ClosedPublicActions