Differential D5492

identifiers: Fix some invalid ValidationError template string formats
ClosedPublic
Actions

Authored by anlambert on Apr 13 2021, 12:46 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3234: Handle gracefully trailing slashes when resolving SWHID in search box

Commits

rDMOD15d5bab5124f: identifiers: Fix some invalid ValidationError template string formats

Summary

Some ValidationError exceptions could not be serialized to string due
to these format errors.

Related to T3234

Diff Detail

Repository

rDMOD Data model

Branch

fix-validation-error-string-serialization-errors

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20663
Build 32064: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 32063: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 13 2021, 12:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 13 2021, 12:46 PM

anlambert mentioned this in T3234: Handle gracefully trailing slashes when resolving SWHID in search box.Apr 13 2021, 12:47 PM

Build is green

Patch application report for D5492 (id=19635)

Rebasing onto f2dba177ad...

Current branch diff-target is up to date.

Changes applied before test

commit 15d5bab5124ff6baf8b2045a50dc2ba27c6714cd
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Apr 13 12:43:48 2021 +0200

    identifiers: Fix some invalid ValidationError template string formats
    
    Some ValidationError exceptions could not be serialized to string due
    to these format errors.
    
    Related to T3234

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/314/ for more details.

Harbormaster completed remote builds in B20663: Diff 19635.Apr 13 2021, 12:48 PM

anlambert requested review of this revision.Apr 13 2021, 12:48 PM

anlambert mentioned this in T3247: Implement SWHID validation in frontend.Apr 13 2021, 12:49 PM

ardumont accepted this revision.Apr 13 2021, 1:12 PM

This revision is now accepted and ready to land.Apr 13 2021, 1:12 PM

Closed by commit rDMOD15d5bab5124f: identifiers: Fix some invalid ValidationError template string formats (authored by anlambert). · Explain WhyApr 13 2021, 2:02 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDMOD15d5bab5124f: identifiers: Fix some invalid ValidationError template string formats.

oops, good catch