Differential D545

Rewrite snapshot pagination tests declaratively
ClosedPublic
Actions

Authored by olasd on Oct 17 2018, 4:56 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rDSTOC0d52bf43cd66: Rewrite snapshot pagination tests declaratively
R65:0d52bf43cd66: Rewrite snapshot pagination tests declaratively
rDSTO0d52bf43cd66: Rewrite snapshot pagination tests declaratively

Summary

This looks less confusing than removing a bunch of values from the test data.

Test Plan

make test still passes

Diff Detail

Repository

rDSTO Storage manager

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1675
Build 2019: arc lint + arc unit

Event Timeline

olasd created this revision.Oct 17 2018, 4:56 PM

Harbormaster completed remote builds in B1675: Diff 1683.Oct 17 2018, 4:56 PM

olasd added a child revision: D546: Rewrite snapshot_get in terms of snapshot_get_branches.Oct 17 2018, 4:56 PM

Indeed, that's clearer.

This revision is now accepted and ready to land.Oct 17 2018, 4:58 PM

Closed by commit rDSTO0d52bf43cd66: Rewrite snapshot pagination tests declaratively (authored by olasd). · Explain WhyOct 17 2018, 4:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

storage/

tests/

test_storage.py

65 lines

Diff 1683

swh/storage/tests/test_storage.py

Loading...