Page MenuHomeSoftware Heritage

docker/tests: Fix symlink handling in test_vault_directory
ClosedPublic

Authored by anlambert on Thu, Apr 8, 2:49 PM.

Details

Summary

The issue appeared since the introduction of a symbolic link in
the swh-core repository used as test input.

Closes T3181

Depends on D5454

Diff Detail

Repository
rDENV Development environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Thu, Apr 8, 2:58 PM
vlorentz added a subscriber: vlorentz.

I don't like this test... it feels like it's re-implementing part of the vault and comparing the two impls...

docker/tests/test_vault.py
45–53

please,

if C: A
else: B

instead of

if not C: B
else: A

val's suggestion is good to ;)