docker/tests: Fix symlink handling in test_vault_directory
ClosedPublic
Actions

Authored by anlambert on Apr 8 2021, 2:49 PM.

Details

Reviewers

ardumont
vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3181: docker-dev: fix vault test which fails the build

Commits

rDENV80e43a5fbe72: docker/tests: Fix symlink handling in test_vault_directory

Summary

The issue appeared since the introduction of a symbolic link in
the swh-core repository used as test input.

Closes T3181

Depends on D5454

Diff Detail

Repository

rDENV Development environment

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 8 2021, 2:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 8 2021, 2:49 PM

anlambert requested review of this revision.Apr 8 2021, 2:49 PM

Harbormaster completed remote builds in B20534: Diff 19492.Apr 8 2021, 2:49 PM

ardumont accepted this revision.Apr 8 2021, 2:58 PM

This revision is now accepted and ready to land.Apr 8 2021, 2:58 PM

I don't like this test... it feels like it's re-implementing part of the vault and comparing the two impls...

docker/tests/test_vault.py
45–53	please, if C: A else: B instead of if not C: B else: A

val's suggestion is good to ;)

Rebase and apply @vlorentz comment.

Harbormaster completed remote builds in B20544: Diff 19503.Apr 8 2021, 3:53 PM

Closed by commit rDENV80e43a5fbe72: docker/tests: Fix symlink handling in test_vault_directory (authored by anlambert). · Explain WhyApr 8 2021, 4:28 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDENV80e43a5fbe72: docker/tests: Fix symlink handling in test_vault_directory.

Revision Contents
Changeset List

Path

Size

docker/

tests/

test_vault.py

10 lines

Diff 19511

View Options

docker/tests/test_vault.py

docker/tests: Fix symlink handling in test_vault_directoryClosedPublicActions