Page MenuHomeSoftware Heritage

HgBundle20Loader: Write nodeids to ExtID objects instead of Revision
ClosedPublic

Authored by vlorentz on Tue, Apr 6, 2:45 PM.

Details

Diff Detail

Repository
rDLDHG Mercurial loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5425 (id=19385)

Could not rebase; Attempt merge onto d35b2692b5...

Updating d35b269..cc04dd0
Fast-forward
 swh/loader/mercurial/from_disk.py            | 46 +++++++---------------------
 swh/loader/mercurial/loader.py               | 19 ++++++++++--
 swh/loader/mercurial/tests/test_from_disk.py | 22 ++++++-------
 swh/loader/mercurial/tests/test_loader.py    |  9 ++++--
 4 files changed, 44 insertions(+), 52 deletions(-)
Changes applied before test
commit cc04dd0bd008b084977a9f4820cdf592c4b806f0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Apr 6 14:39:44 2021 +0200

    HgBundle20Loader: Write nodeids to ExtID objects instead of Revision
    
    We want ro remove Revision.metadata.
    
    This aligns HgBundle20Loader's behavior on HgLoaderFromDisk's.

commit 15389dca90d612265a6fc183e2231187d2635a05
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Apr 6 14:40:50 2021 +0200

    HgLoaderFromDisk: Stop reading/writing Revision.metadata
    
    It already writes it with raw_extrinsic_metadata_add/extid_add,
    and read it with extid_get_*.
    
    This code was only kept for compatibility while we were migrating
    the extids. This is now done, so this code is useless.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/200/ for more details.

This revision is now accepted and ready to land.Tue, Apr 6, 2:52 PM