Differential D5319

deposit.auth: Namespace cache keys per realm, client_id and user_id
ClosedPublic
Actions

Authored by ardumont on Mar 24 2021, 4:37 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3166: Deploy deposit v0.13 in staging

Commits

rDDEPcea9b0ba62f5: deposit.auth: Namespace cache keys per realm, client_id and user_id

Summary

The cache may [1] or may not [2] be shared with other applications. So best avoiding
clash altogether.

[1] moma has both the deposit and the webapp which both *will* use the same cache

[2] deposit and webapp in staging are standalone apps so no sharing there.

Related to T3166

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 20172
Build 31316: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 31315: arc lint + arc unit

Event Timeline

ardumont created this revision.Mar 24 2021, 4:37 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 24 2021, 4:37 PM

Build is green

Patch application report for D5319 (id=19080)

Rebasing onto 984fe30ae2...

Current branch diff-target is up to date.

Changes applied before test

commit cea9b0ba62f53c917dce6d26ff9cc84a32d8116d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Mar 24 16:31:39 2021 +0100

    deposit.auth: Namespace cache keys per realm, client_id and user_id
    
    The cache may [1] or may not [2] be shared with other applications. So best avoiding
    clash altogether.
    
    [1] moma has both the deposit and the webapp which both *will* use the same cache
    
    [2] deposit and webapp in staging are standalone apps so no sharing there.
    
    Related to T3166

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/597/ for more details.

Harbormaster completed remote builds in B20172: Diff 19080.Mar 24 2021, 4:39 PM

ardumont requested review of this revision.Mar 24 2021, 4:39 PM

Looks good to me.

This revision is now accepted and ready to land.Mar 24 2021, 4:46 PM

ardumont edited the test plan for this revision. (Show Details)Mar 24 2021, 4:46 PM

Closed by commit rDDEPcea9b0ba62f5: deposit.auth: Namespace cache keys per realm, client_id and user_id (authored by ardumont). · Explain WhyMar 24 2021, 4:48 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEPcea9b0ba62f5: deposit.auth: Namespace cache keys per realm, client_id and user_id.