auth: Use KeycloakOpenIDConnect class and fixture factory from swh-auth
ClosedPublic
Actions

Authored by anlambert on Mar 22 2021, 7:09 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3150: Move generic django authentication code to swh-auth

Commits

rDWAPPS9b2507a81b4b: auth: Use KeycloakOpenIDConnect class and fixture factory from swh-auth

Summary

The KeycloakOpenIDConnect class and its mocked version have been moved
to the swh-auth module in order to reuse them across multiple modules.

So remove duplicated code and adapt tests to use the fixture factory
function from swh.auth.pytest_plugin.

Related to T3150

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Mar 22 2021, 7:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 22 2021, 7:09 PM

anlambert edited the summary of this revision. (Show Details)Mar 22 2021, 7:09 PM

Build is green

Patch application report for D5303 (id=18992)

Rebasing onto 65c0037d90...

Current branch diff-target is up to date.

Changes applied before test

commit 9b2507a81b4b30da13ee4f8d612bf85280fd04f4
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Mar 22 19:02:24 2021 +0100

    auth: Use KeycloakOpenIDConnect class and fixture factory from swh-auth
    
    The KeycloakOpenIDConnect class and its mocked version have been moved
    to the swh-auth module in order to reuse them across multiple modules.
    
    So remove duplicated code and adapt tests to use the fixture factory
    function from swh.auth.pytest_plugin.
    
    Related to T3150

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/632/ for more details.

Harbormaster completed remote builds in B20069: Diff 18992.Mar 22 2021, 7:17 PM

anlambert requested review of this revision.Mar 22 2021, 7:17 PM

ardumont added a subscriber: ardumont.Mar 22 2021, 7:20 PM

ardumont added inline comments.