Page MenuHomeSoftware Heritage

swh-counters: Implement the cli skeleton
ClosedPublic

Authored by vsellier on Mar 10 2021, 4:30 PM.

Details

Summary

The counters logic is not yet implemented

Related to T2912

Test Plan

tox + tested with docker (no yet comitted)

Diff Detail

Repository
rDCNT Archive counters
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 10 2021, 4:30 PM
Harbormaster failed remote builds in B19828: Diff 18733!

Build is green

Patch application report for D5229 (id=18734)

Rebasing onto 142fff8430...

Current branch diff-target is up to date.
Changes applied before test
commit 2416f1e181a7a1e3913bcf76f0f0e2059600f2f0
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Mar 10 16:25:49 2021 +0100

    Command line skeleton
    
    Related to T2912

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/3/ for more details.

Build is green

Patch application report for D5229 (id=18740)

Rebasing onto 142fff8430...

Current branch diff-target is up to date.
Changes applied before test
commit b2923e7b49eeb06a4599b03e3407b4daa32851a9
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Mar 10 16:25:49 2021 +0100

    Command line skeleton
    
    Related to T2912

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/4/ for more details.

vsellier retitled this revision from wip - Command line skeleton to Command line skeleton.Mar 11 2021, 12:20 PM
vsellier edited the summary of this revision. (Show Details)
vsellier edited the test plan for this revision. (Show Details)
vsellier added a project: Counters.
vsellier edited the test plan for this revision. (Show Details)

looks good to me (i did not read through the tests yet though).

Note that the commit message should be rework to use
an imperative style [1]

[1] http://chris.beams.io/posts/git-commit/

swh/counters/kafka_client.py
18

Maybe concentrate on what this implementation is about first.

Journal Client implementation which only uses the message keys.
This does not need to bother with the message deserialization (contrary 
to`swh.journal.client.JournalClient`)
swh/counters/tests/test_cli.py
20

Drop those unneeded comment.

Build is green

Patch application report for D5229 (id=18759)

Rebasing onto 142fff8430...

Current branch diff-target is up to date.
Changes applied before test
commit b1f6988c37b1950f1e856e8af46c251ab3b2e568
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Mar 10 16:25:49 2021 +0100

    Implement the cli skeleton
    
    No counters logic is not yet implemented
    
    Related to T2912

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/5/ for more details.

vsellier retitled this revision from Command line skeleton to swh-counters: Implement the cli skeleton.Mar 12 2021, 9:48 AM
vsellier edited the summary of this revision. (Show Details)

Build is green

Patch application report for D5229 (id=18760)

Rebasing onto 142fff8430...

Current branch diff-target is up to date.
Changes applied before test
commit 826c30e4b74cffd34d3dca0bd6312572353b0448
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Mar 10 16:25:49 2021 +0100

    Implement the cli skeleton
    
    The counters logic is not yet implemented
    
    Related to T2912

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/6/ for more details.

This revision is now accepted and ready to land.Mar 12 2021, 9:54 AM
This revision was automatically updated to reflect the committed changes.