The counters logic is not yet implemented
Related to T2912
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T2912: Next generation archive counters
- Commits
- rDCNT826c30e4b74c: Implement the cli skeleton
tox + tested with docker (no yet comitted)
Diff Detail
Diff Detail
- Repository
- rDCNT Archive counters
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19829 Build 30793: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 30792: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/1/
See console output for more information: https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/1/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/2/
See console output for more information: https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/2/console
Comment Actions
Build is green
Patch application report for D5229 (id=18734)
Rebasing onto 142fff8430...
Current branch diff-target is up to date.
Changes applied before test
commit 2416f1e181a7a1e3913bcf76f0f0e2059600f2f0
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date: Wed Mar 10 16:25:49 2021 +0100
Command line skeleton
Related to T2912See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/3/ for more details.
Comment Actions
Build is green
Patch application report for D5229 (id=18740)
Rebasing onto 142fff8430...
Current branch diff-target is up to date.
Changes applied before test
commit b2923e7b49eeb06a4599b03e3407b4daa32851a9
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date: Wed Mar 10 16:25:49 2021 +0100
Command line skeleton
Related to T2912See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/4/ for more details.
Comment Actions
looks good to me (i did not read through the tests yet though).
Note that the commit message should be rework to use
an imperative style [1]
| swh/counters/kafka_client.py | ||
|---|---|---|
| 18 | Maybe concentrate on what this implementation is about first. Journal Client implementation which only uses the message keys. This does not need to bother with the message deserialization (contrary to`swh.journal.client.JournalClient`) | |
| swh/counters/tests/test_cli.py | ||
| 20 ↗ | (On Diff #18740) | Drop those unneeded comment. |
Comment Actions
Build is green
Patch application report for D5229 (id=18759)
Rebasing onto 142fff8430...
Current branch diff-target is up to date.
Changes applied before test
commit b1f6988c37b1950f1e856e8af46c251ab3b2e568
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date: Wed Mar 10 16:25:49 2021 +0100
Implement the cli skeleton
No counters logic is not yet implemented
Related to T2912See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/5/ for more details.
Comment Actions
Build is green
Patch application report for D5229 (id=18760)
Rebasing onto 142fff8430...
Current branch diff-target is up to date.
Changes applied before test
commit 826c30e4b74cffd34d3dca0bd6312572353b0448
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date: Wed Mar 10 16:25:49 2021 +0100
Implement the cli skeleton
The counters logic is not yet implemented
Related to T2912See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/6/ for more details.