Page MenuHomeSoftware Heritage
Differential D5229

swh-counters: Implement the cli skeleton
ClosedPublic
Actions

Authored by vsellier on Mar 10 2021, 4:30 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T2912: Next generation archive counters
Commits
rDCNT826c30e4b74c: Implement the cli skeleton
Summary

The counters logic is not yet implemented

Related to T2912

Test Plan

tox + tested with docker (no yet comitted)

Diff Detail

Repository
rDCNT Archive counters
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19856
Build 30839: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 30838: arc lint + arc unit

Event Timeline

vsellier created this revision.Mar 10 2021, 4:30 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 10 2021, 4:30 PM
swh-public-ci added a comment.Mar 10 2021, 4:30 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/1/
See console output for more information: https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/1/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 10 2021, 4:30 PM
Harbormaster failed remote builds in B19828: Diff 18733!
swh-public-ci added a comment.Mar 10 2021, 4:37 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/2/
See console output for more information: https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/2/console

vsellier updated this revision to Diff 18734.Mar 10 2021, 4:42 PM

fix tox

swh-public-ci added a comment.Mar 10 2021, 4:42 PM

Build is green

Patch application report for D5229 (id=18734)

Rebasing onto 142fff8430...

Current branch diff-target is up to date.
Changes applied before test
commit 2416f1e181a7a1e3913bcf76f0f0e2059600f2f0
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Mar 10 16:25:49 2021 +0100

    Command line skeleton
    
    Related to T2912

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/3/ for more details.

Harbormaster completed remote builds in B19829: Diff 18734.Mar 10 2021, 4:43 PM
vsellier requested review of this revision.Mar 10 2021, 4:43 PM
vsellier planned changes to this revision.Mar 10 2021, 4:43 PM
vsellier updated this revision to Diff 18740.Mar 11 2021, 12:09 PM

Add tests

swh-public-ci added a comment.Mar 11 2021, 12:10 PM

Build is green

Patch application report for D5229 (id=18740)

Rebasing onto 142fff8430...

Current branch diff-target is up to date.
Changes applied before test
commit b2923e7b49eeb06a4599b03e3407b4daa32851a9
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Mar 10 16:25:49 2021 +0100

    Command line skeleton
    
    Related to T2912

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/4/ for more details.

Harbormaster completed remote builds in B19836: Diff 18740.Mar 11 2021, 12:10 PM
vsellier retitled this revision from wip - Command line skeleton to Command line skeleton.Mar 11 2021, 12:20 PM
vsellier edited the summary of this revision. (Show Details)
vsellier edited the test plan for this revision. (Show Details)
vsellier added a project: Counters.
vsellier edited the test plan for this revision. (Show Details)Mar 11 2021, 2:39 PM
vsellier edited the test plan for this revision. (Show Details)
ardumont added a subscriber: ardumont.Mar 11 2021, 5:08 PM

looks good to me (i did not read through the tests yet though).

Note that the commit message should be rework to use
an imperative style [1]

[1] http://chris.beams.io/posts/git-commit/

swh/counters/kafka_client.py
18

Maybe concentrate on what this implementation is about first.

Journal Client implementation which only uses the message keys.
This does not need to bother with the message deserialization (contrary 
to`swh.journal.client.JournalClient`)
swh/counters/tests/test_cli.py
20

Drop those unneeded comment.

vsellier updated this revision to Diff 18759.Mar 12 2021, 9:46 AM

Fix review feedbacks

vsellier updated this revision to Diff 18760.Mar 12 2021, 9:46 AM

Update the commit message

swh-public-ci added a comment.Mar 12 2021, 9:47 AM

Build is green

Patch application report for D5229 (id=18759)

Rebasing onto 142fff8430...

Current branch diff-target is up to date.
Changes applied before test
commit b1f6988c37b1950f1e856e8af46c251ab3b2e568
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Mar 10 16:25:49 2021 +0100

    Implement the cli skeleton
    
    No counters logic is not yet implemented
    
    Related to T2912

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/5/ for more details.

Harbormaster completed remote builds in B19855: Diff 18759.Mar 12 2021, 9:47 AM
vsellier retitled this revision from Command line skeleton to swh-counters: Implement the cli skeleton.Mar 12 2021, 9:48 AM
vsellier edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Mar 12 2021, 9:48 AM

Build is green

Patch application report for D5229 (id=18760)

Rebasing onto 142fff8430...

Current branch diff-target is up to date.
Changes applied before test
commit 826c30e4b74cffd34d3dca0bd6312572353b0448
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Mar 10 16:25:49 2021 +0100

    Implement the cli skeleton
    
    The counters logic is not yet implemented
    
    Related to T2912

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/6/ for more details.

Harbormaster completed remote builds in B19856: Diff 18760.Mar 12 2021, 9:48 AM
ardumont accepted this revision.Mar 12 2021, 9:54 AM

lgtm

This revision is now accepted and ready to land.Mar 12 2021, 9:54 AM
Closed by commit rDCNT826c30e4b74c: Implement the cli skeleton (authored by vsellier). · Explain WhyMar 12 2021, 10:05 AM
This revision was automatically updated to reflect the committed changes.
vsellier added a commit: rDCNT826c30e4b74c: Implement the cli skeleton.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
3 lines--
1 line--
2 lines--
1 line--
8 lines--
swh/
5 lines92%
Loading...
counters/
44 lines--
api/
--
api/
14 lines100%
Loading...
85 lines94%
Loading...
28 lines72%
Loading...
11 lines66%
Loading...
48 lines84%
Loading...
20 lines70%
Loading...
tests/
26 lines100%
Loading...
209 lines100%
Loading...
71 lines82%
Loading...
--

Diff 18760

View Options

mypy.ini

Loading...
View Options

requirements-swh.txt

Loading...
View Options

requirements-test.txt

Loading...
View Options

requirements.txt

Loading...
View Options

setup.py

Loading...
View Options

swh/__init__.py

Loading...
View Options

swh/counters/__init__.py

Loading...
View Options

swh/counters/api/__init__.py

Loading...
View Options

swh/counters/api/client.py

Loading...
View Options

swh/counters/cli.py

Loading...
View Options

swh/counters/interface.py

Loading...
View Options

swh/counters/journal_client.py

Loading...
View Options

swh/counters/kafka_client.py

Loading...
View Options

swh/counters/redis.py

Loading...
View Options

swh/counters/tests/conftest.py

Loading...
View Options

swh/counters/tests/test_cli.py

Loading...
View Options

swh/counters/tests/test_init.py

Loading...
View Options

swh/counters/tests/test_nothing.py

Loading...
About · Developer information · Legal