test_cli: Fix test_run_help and test_list_help
ClosedPublic
Actions

Authored by anlambert on Mar 8 2021, 12:50 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDBASE132522e42ec9: test_cli: Fix test_run_help and test_list_help

Summary

Due to an incomplete command passed to the HelpFormatter.format method,
the text alignment in the usage_prefix variable was not the same as the
command output generated by click.

Those tests started to fail since the recent growth of available loaders
as click wraps help lines to 80 columns.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

test-cli-fixes

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19775
Build 30702: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 30701: arc lint + arc unit

Event Timeline

anlambert created this revision.Mar 8 2021, 12:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 8 2021, 12:50 PM

Build is green

Patch application report for D5214 (id=18682)

Rebasing onto d14fbd2a9f...

Current branch diff-target is up to date.

Changes applied before test

commit 132522e42ec96b4946671bfabc28378fac72ee6a
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Mar 8 12:48:29 2021 +0100

    test_cli: Fix test_run_help and test_list_help
    
    Due to an incomplete command passed to the HelpFormatter.format method,
    the text alignment in the usage_prefix variable was not the same as the
    command output generated by click.
    
    Those tests started to fail since the recent growth of available loaders
    as click wraps help lines to 80 columns.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/401/ for more details.

Harbormaster completed remote builds in B19775: Diff 18682.Mar 8 2021, 12:52 PM

anlambert requested review of this revision.Mar 8 2021, 12:52 PM

anlambert edited the summary of this revision. (Show Details)Mar 8 2021, 12:52 PM

vlorentz accepted this revision.Mar 8 2021, 1:33 PM

This revision is now accepted and ready to land.Mar 8 2021, 1:33 PM

Closed by commit rDLDBASE132522e42ec9: test_cli: Fix test_run_help and test_list_help (authored by anlambert). · Explain WhyMar 8 2021, 2:10 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDBASE132522e42ec9: test_cli: Fix test_run_help and test_list_help.