Paths

Table of Contentst

Differential D5201

keycloak: Open from_config* method to instantiate KeycloakOpenIDConnect
ClosedPublic
Actions

Authored by ardumont on Mar 5 2021, 2:12 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3079: Boostrap swh-auth module for authentication

Commits

rDAUTHfa523d66b63a: keycloak: Open from_config* method to instantiate KeycloakOpenIDConnect

Summary

Related to T3079

Diff Detail

Repository

rDAUTH Common authentication libraries

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19732
Build 30628: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 30627: arc lint + arc unit

Event Timeline

ardumont created this revision.Mar 5 2021, 2:12 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 5 2021, 2:12 PM

Build is green

Patch application report for D5201 (id=18636)

Rebasing onto bd3d8437f1...

Current branch diff-target is up to date.

Changes applied before test

commit 16d48b094f3e808bcb3cbe2f5c4d36114a433853
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Mar 5 14:11:13 2021 +0100

    keycloak: Open from_config* method to instantiate KeycloakOpenIDConnect
    
    Related to T3079

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/15/ for more details.

Harbormaster completed remote builds in B19731: Diff 18636.Mar 5 2021, 2:13 PM

ardumont requested review of this revision.Mar 5 2021, 2:13 PM

anlambert added a subscriber: anlambert.Mar 5 2021, 2:16 PM

anlambert added inline comments.

swh/auth/keycloak.py
181	You should allow to override the config with keyword arguments (as in listers). config = dict(load_from_envvar()) config.update({k: v for k, v in kwargs.items() if v is not None}) This is useful for testing.

ardumont added inline comments.Mar 5 2021, 2:18 PM

swh/auth/keycloak.py
181	interesting, i did not notice, thx

Adapt according to review about allowing override from calling the from_configfile method.

Also add missing docstrings.

Build is green

Patch application report for D5201 (id=18637)

Rebasing onto bd3d8437f1...

Current branch diff-target is up to date.

Changes applied before test

commit a44082d1872a9e55c9ab97ad01aadab2b7c44028
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Mar 5 14:11:13 2021 +0100

    keycloak: Open from_config* method to instantiate KeycloakOpenIDConnect
    
    Related to T3079

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/16/ for more details.

Harbormaster completed remote builds in B19732: Diff 18637.Mar 5 2021, 2:33 PM

anlambert added inline comments.Mar 5 2021, 2:35 PM

swh/auth/keycloak.py
200	You should use `.get("keycloak", {})` to avoid possible error

Adapt according to last suggestion (thx)

Build is green

Patch application report for D5201 (id=18638)

Rebasing onto bd3d8437f1...

Current branch diff-target is up to date.

Changes applied before test

commit fa523d66b63a2a3bc02f78957e37d9b2078a8baf
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Mar 5 14:11:13 2021 +0100

    keycloak: Open from_config* method to instantiate KeycloakOpenIDConnect
    
    Related to T3079

See https://jenkins.softwareheritage.org/job/DAUTH/job/tests-on-diff/17/ for more details.

Harbormaster completed remote builds in B19733: Diff 18638.Mar 5 2021, 2:39 PM

anlambert accepted this revision.Mar 5 2021, 2:39 PM

This revision is now accepted and ready to land.Mar 5 2021, 2:39 PM

Closed by commit rDAUTHfa523d66b63a: keycloak: Open from_config* method to instantiate KeycloakOpenIDConnect (authored by ardumont). · Explain WhyMar 5 2021, 2:45 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDAUTHfa523d66b63a: keycloak: Open from_config* method to instantiate KeycloakOpenIDConnect.