Before this commit, load status 'success' and 'failed' updated the
deposit status accordingly, but other statuses were ignored.
Partially fixes T3070.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T3070: Fix longstanding deposit status verified which is usually a symptom of loading failure
- Commits
- rDLDBASEb5a7fee0725e: deposit: Update deposit status when the load status is 'partial'
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19459 Build 30189: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 30188: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D5139 (id=18378)
Rebasing onto 52626cbb04...
Current branch diff-target is up to date.
Changes applied before test
commit 9eb37bda3161705fb238227fed7e61a3eecb0426
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Feb 25 11:44:24 2021 +0100
deposit: Update deposit status when the load status is 'partial'
Before this commit, load status 'success' and 'failed' updated the
deposit status accordingly, but other statuses were ignored.Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/381/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/381/console
Comment Actions
Build is green
Patch application report for D5139 (id=18381)
Could not rebase; Attempt merge onto 52626cbb04...
Updating 52626cb..b5a7fee Fast-forward swh/loader/package/deposit/loader.py | 7 +- swh/loader/package/deposit/tests/test_deposit.py | 18 ++++ swh/loader/package/loader.py | 128 ++++++++++++++--------- 3 files changed, 102 insertions(+), 51 deletions(-)
Changes applied before test
commit b5a7fee0725e6be6e62715980a78bce4c39c9419
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Feb 25 11:44:24 2021 +0100
deposit: Update deposit status when the load status is 'partial'
Before this commit, load status 'success' and 'failed' updated the
deposit status accordingly, but other statuses were ignored.
commit e80919ed8e7bf882746faddda19706139ffa161f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Feb 25 11:48:24 2021 +0100
Make finalize_visit a method instead of nested function.
I don't see the point of it being a nested function, it just makes load()
larger.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/384/ for more details.