Differential D5140

Make finalize_visit a method instead of nested function.
ClosedPublic
Actions

Authored by vlorentz on Feb 25 2021, 11:48 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASEe80919ed8e7b: Make finalize_visit a method instead of nested function.

Summary

I don't see the point of it being a nested function, it just makes load()
larger.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 25 2021, 11:48 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 25 2021, 11:48 AM

Build has FAILED

Patch application report for D5140 (id=18379)

Could not rebase; Attempt merge onto 52626cbb04...

Updating 52626cb..3578d6e
Fast-forward
 swh/loader/package/deposit/loader.py             |   2 +-
 swh/loader/package/deposit/tests/test_deposit.py |  18 ++++
 swh/loader/package/loader.py                     | 127 ++++++++++++++---------
 3 files changed, 97 insertions(+), 50 deletions(-)

Changes applied before test

commit 3578d6eec5cac943a52ab6ac8ceb6c25615778a8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 25 11:48:24 2021 +0100

    Make finalize_visit a method instead of nested function.
    
    I don't see the point of it being a nested function, it just makes load()
    larger.

commit 9eb37bda3161705fb238227fed7e61a3eecb0426
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 25 11:44:24 2021 +0100

    deposit: Update deposit status when the load status is 'partial'
    
    Before this commit, load status 'success' and 'failed' updated the
    deposit status accordingly, but other statuses were ignored.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/382/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/382/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 25 2021, 11:50 AM

Harbormaster failed remote builds in B19457: Diff 18379!

rebase under D5139

vlorentz mentioned this in D5139: deposit: Update deposit status when the load status is 'partial'.Feb 25 2021, 11:59 AM

Build is green

Patch application report for D5140 (id=18380)

Rebasing onto 52626cbb04...

Current branch diff-target is up to date.

Changes applied before test

commit e80919ed8e7bf882746faddda19706139ffa161f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Feb 25 11:48:24 2021 +0100

    Make finalize_visit a method instead of nested function.
    
    I don't see the point of it being a nested function, it just makes load()
    larger.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/383/ for more details.

Harbormaster completed remote builds in B19458: Diff 18380.Feb 25 2021, 12:01 PM

vlorentz requested review of this revision.Feb 25 2021, 12:01 PM