Paths

Table of Contentst

Differential D5099

Make ArchiveStorage() accept a StorageInterface object as argument
ClosedPublic
Actions

Authored by douardda on Feb 17 2021, 5:37 PM.

Details

Reviewers

aeviso

Commits

rDPROV5b84f74dded5: Make ArchiveStorage() accept a StorageInterface object as argument

Summary

instead of the parameters to pass to the get_storage() factory function.
This will help for writing tests, since the storage is usually
instanciated by a pytest fixture.

Depends on D5098.

Diff Detail

Repository

rDPROV Provenance database

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda requested review of this revision.Feb 17 2021, 5:37 PM

douardda created this revision.

Harbormaster completed remote builds in B19305: Diff 18206.Feb 17 2021, 5:37 PM

douardda added a child revision: D5100: Refactor the FileRevisionIterator.Feb 17 2021, 5:37 PM

aeviso accepted this revision.Feb 18 2021, 1:56 PM

aeviso added a subscriber: aeviso.

aeviso added inline comments.

swh/provenance/__init__.py
19	Not sure how `swh db` works but should we use it to handle this connection as well?

This revision is now accepted and ready to land.Feb 18 2021, 1:56 PM

rebase

Harbormaster completed remote builds in B19359: Diff 18265.Feb 18 2021, 5:58 PM

Closed by commit rDPROV5b84f74dded5: Make ArchiveStorage() accept a StorageInterface object as argument (authored by douardda). · Explain WhyFeb 19 2021, 10:02 AM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDPROV5b84f74dded5: Make ArchiveStorage() accept a StorageInterface object as argument.

Revision Contents
Changeset List

Path

Size

swh/

provenance/

__init__.py

6 lines

storage/

archive.py

6 lines

Diff 18282

View Options

swh/provenance/init.py

View Options

swh/provenance/storage/archive.py

Make ArchiveStorage() accept a StorageInterface object as argumentClosedPublicActions