Page MenuHomeSoftware Heritage
Differential D4947

scanner-benchmark: algo_min fixed, retry mechanism on request error
ClosedPublic
Actions

Authored by DanSeraf on Jan 26 2021, 12:26 PM.

Details

Reviewers
zack
Group Reviewers
Reviewers
Commits
rDTSCN5e01c09af4c6: retry request in case of backend failure
rDTSCNebad16c02da6: algo_min: remove the current node as well

Diff Detail

Repository
rDTSCN Code scanner
Branch
benchmark
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18744
Build 29015: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 29014: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
143 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_backend::test_backend_endpoint_all_present
tmp_path = PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_backend_endpoint_all_pres0') live_server = <LiveServer listening at http://localhost:6600> test_swhids_sample = <_io.TextIOWrapper name='/tmp/pytest-of-jenkins/pytest-0/test_backend_endpoint_all_pres0/swhids_sample.txt' mode='r' encoding='UTF-8'>
4 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_backend::test_backend_endpoint_one_not_present
tmp_path = PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_backend_endpoint_one_not_0') live_server = <LiveServer listening at http://localhost:6600> test_swhids_sample = <_io.TextIOWrapper name='/tmp/pytest-of-jenkins/pytest-0/test_backend_endpoint_one_not_0/swhids_sample.txt' mode='r' encoding='UTF-8'>
4 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_backend::test_backend_large_payload_exc
tmp_path = PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_backend_large_payload_exc0') live_server = <LiveServer listening at http://localhost:6600> test_swhids_sample = <_io.TextIOWrapper name='/tmp/pytest-of-jenkins/pytest-0/test_backend_large_payload_exc0/swhids_sample.txt' mode='r' encoding='UTF-8'>
3 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_dashboard::test_generate_table_body
example_tree = <swh.scanner.model.Tree object at 0x7f8ec6a0f940> temp_folder = {'filesample': PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_generate_table_body0/subdir/filesample.txt'), 'filesamp...b9a060e54bf8d69288fbee4904', ...}, 'root': PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_generate_table_body0'), ...}
2 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.scanner.tests.test_model::test_get_directories_info
example_tree = <swh.scanner.model.Tree object at 0x7f8ec6a3a518> temp_folder = {'filesample': PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_get_directories_info0/subdir/filesample.txt'), 'filesam...9a060e54bf8d69288fbee4904', ...}, 'root': PosixPath('/tmp/pytest-of-jenkins/pytest-0/test_get_directories_info0'), ...}
View Full Test Results (17 Failed · 18 Passed)

Event Timeline

DanSeraf created this revision.Jan 26 2021, 12:26 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 26 2021, 12:26 PM
swh-public-ci added a comment.Jan 26 2021, 12:28 PM

Build has FAILED

Patch application report for D4947 (id=17605)

Could not rebase; Attempt merge onto 33a9cd4eb9...

Auto-merging swh/scanner/cli.py
Merge made by the 'recursive' strategy.
 benchmark.py                   | 136 ++++++++++++++
 run_backend.sh                 |  15 ++
 run_benchmark.sh               |  37 ++++
 swh/scanner/backend.py         |  16 +-
 swh/scanner/benchmark_algos.py | 392 +++++++++++++++++++++++++++++++++++++++++
 swh/scanner/cli.py             |  73 ++++++++
 swh/scanner/model.py           |  54 +++++-
 7 files changed, 712 insertions(+), 11 deletions(-)
 create mode 100755 benchmark.py
 create mode 100755 run_backend.sh
 create mode 100755 run_benchmark.sh
 create mode 100644 swh/scanner/benchmark_algos.py
Changes applied before test
commit 99acd6060774103e9487b6d546d10b04deed4b9f
Merge: 33a9cd4 dbd136e
Author: Jenkins user <jenkins@localhost>
Date:   Tue Jan 26 11:26:28 2021 +0000

    Merge branch 'diff-target' into HEAD

commit dbd136e4dfbf92c69f83502d757f9cde9ecd1aba
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Tue Jan 26 10:10:00 2021 +0100

    retry mechanism in case of backend failure

commit a0b83c48f3f1714b1b4605657ec63d994a6ec0e5
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Mon Jan 25 13:48:14 2021 +0100

    the current node in algo_min must be removed

commit 5cd9f762467ece41d7d8e1ae1841e1d24aad45e4
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Mon Jan 18 10:26:06 2021 +0100

    fix: the temporary directory is removed by tempfile

commit 7a289332f73025f94f7f85ab5bd6755b876ebe68
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Tue Jan 12 23:12:18 2021 +0100

    print results as a csv

commit 9e4df16d9486a891498124dd4cfb7558c57dfa0c
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Tue Jan 12 23:10:39 2021 +0100

    extract repositories in temporary directories

commit 7bd1939949dcbcf0c52b8647f2b1750f2c9d2300
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Thu Dec 10 23:59:31 2020 +0100

    scanner experiments

Link to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/91/
See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/91/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 26 2021, 12:28 PM
Harbormaster failed remote builds in B18744: Diff 17605!
DanSeraf requested review of this revision.Jan 26 2021, 12:42 PM
vlorentz added a subscriber: vlorentz.Jan 26 2021, 2:51 PM

Nitpick: could you reword the commit to follow this guideline?

It would be nice to have tests for this file, but I guess that's out of scope for this diff.

Do you know why unrelated tests are failing?

zack added a subscriber: zack.Jan 26 2021, 3:00 PM

for context: this change is only going to be committed in a separate branch that we're using for experiments with swh-scanner, hence the testing requirements are different/lower than for master

DanSeraf retitled this revision from scanner-benchmark: algo_mix fixed, retry mechanism on request error to scanner-benchmark: algo_miv fixed, retry mechanism on request error.Jan 26 2021, 3:15 PM
DanSeraf retitled this revision from scanner-benchmark: algo_miv fixed, retry mechanism on request error to scanner-benchmark: algo_min fixed, retry mechanism on request error.
vlorentz added a comment.Jan 26 2021, 3:18 PM

oh, that explains the test failures, thanks

DanSeraf updated this revision to Diff 17628.Jan 26 2021, 3:45 PM

commit message

swh-public-ci added a comment.Jan 26 2021, 3:48 PM

Build has FAILED

Patch application report for D4947 (id=17628)

Could not rebase; Attempt merge onto 33a9cd4eb9...

Auto-merging swh/scanner/cli.py
Merge made by the 'recursive' strategy.
 benchmark.py                   | 136 ++++++++++++++
 run_backend.sh                 |  15 ++
 run_benchmark.sh               |  37 ++++
 swh/scanner/backend.py         |  16 +-
 swh/scanner/benchmark_algos.py | 392 +++++++++++++++++++++++++++++++++++++++++
 swh/scanner/cli.py             |  73 ++++++++
 swh/scanner/model.py           |  54 +++++-
 7 files changed, 712 insertions(+), 11 deletions(-)
 create mode 100755 benchmark.py
 create mode 100755 run_backend.sh
 create mode 100755 run_benchmark.sh
 create mode 100644 swh/scanner/benchmark_algos.py
Changes applied before test
commit 3aef643dfeef93141977f45a62fde771adaadf4e
Merge: 33a9cd4 5e01c09
Author: Jenkins user <jenkins@localhost>
Date:   Tue Jan 26 14:46:05 2021 +0000

    Merge branch 'diff-target' into HEAD

commit 5e01c09af4c61a309d71adb0d4f61d1766b8a021
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Tue Jan 26 10:10:00 2021 +0100

    retry request in case of backend failure

commit ebad16c02da6bffbc96a623e082a4b5f706d7b1f
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Mon Jan 25 13:48:14 2021 +0100

    algo_min: remove the current node as well

commit 5cd9f762467ece41d7d8e1ae1841e1d24aad45e4
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Mon Jan 18 10:26:06 2021 +0100

    fix: the temporary directory is removed by tempfile

commit 7a289332f73025f94f7f85ab5bd6755b876ebe68
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Tue Jan 12 23:12:18 2021 +0100

    print results as a csv

commit 9e4df16d9486a891498124dd4cfb7558c57dfa0c
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Tue Jan 12 23:10:39 2021 +0100

    extract repositories in temporary directories

commit 7bd1939949dcbcf0c52b8647f2b1750f2c9d2300
Author: Daniele Serafini <me@danieleserafini.eu>
Date:   Thu Dec 10 23:59:31 2020 +0100

    scanner experiments

Link to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/92/
See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/92/console

Harbormaster failed remote builds in B18766: Diff 17628!Jan 26 2021, 3:48 PM
zack accepted this revision.Jan 28 2021, 10:58 AM
This revision is now accepted and ready to land.Jan 28 2021, 10:58 AM
This revision was landed with ongoing or failed builds.Jan 28 2021, 11:44 AM
Closed by commit rDTSCNebad16c02da6: algo_min: remove the current node as well (authored by DanSeraf). · Explain Why
This revision was automatically updated to reflect the committed changes.
DanSeraf added a commit: rDTSCNebad16c02da6: algo_min: remove the current node as well.
DanSeraf added a commit: rDTSCN5e01c09af4c6: retry request in case of backend failure.

Revision Contents
Changeset List

PathSize
swh/
scanner/
9 lines

Diff 17605

View Options

swh/scanner/benchmark_algos.py

Loading...
About · Developer information · Legal