Page MenuHomeSoftware Heritage

browse/release: Add missing SWHIDs info
ClosedPublic

Authored by anlambert on Jan 21 2021, 12:52 PM.

Details

Summary

SWHID links related to reachable revision, directory or content from a
browsed release were missing in the view.

This fixes the vault cooking task creation for the target directory
through the use of the "Download" link in the release view.

Closes T2982

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D4904 (id=17469)

Rebasing onto e702c28aee...

Current branch diff-target is up to date.
Changes applied before test
commit 7a4bcdea9e52f8b6fc71c98415b9c61dfc1aa56e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jan 21 12:49:31 2021 +0100

    browse/release: Add missing SWHIDs info
    
    SWHID links related to reachable revision, directory or content from a
    browsed release were missing in the view.
    
    This fixes the vault cooking task creation for the target directory
    through the use of the "Download" link in the release view.
    
    Closes T2982

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/552/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/552/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 21 2021, 12:53 PM
Harbormaster failed remote builds in B18603: Diff 17469!

Build has FAILED

Patch application report for D4904 (id=17469)

Rebasing onto e702c28aee...

Current branch diff-target is up to date.
Changes applied before test
commit 7a4bcdea9e52f8b6fc71c98415b9c61dfc1aa56e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jan 21 12:49:31 2021 +0100

    browse/release: Add missing SWHIDs info
    
    SWHID links related to reachable revision, directory or content from a
    browsed release were missing in the view.
    
    This fixes the vault cooking task creation for the target directory
    through the use of the "Download" link in the release view.
    
    Closes T2982

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/553/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/553/console

Build is green

Patch application report for D4904 (id=17469)

Rebasing onto e702c28aee...

Current branch diff-target is up to date.
Changes applied before test
commit 7a4bcdea9e52f8b6fc71c98415b9c61dfc1aa56e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jan 21 12:49:31 2021 +0100

    browse/release: Add missing SWHIDs info
    
    SWHID links related to reachable revision, directory or content from a
    browsed release were missing in the view.
    
    This fixes the vault cooking task creation for the target directory
    through the use of the "Download" link in the release view.
    
    Closes T2982

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/554/ for more details.

Build is green

Patch application report for D4904 (id=17469)

Rebasing onto e702c28aee...

Current branch diff-target is up to date.
Changes applied before test
commit 7a4bcdea9e52f8b6fc71c98415b9c61dfc1aa56e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jan 21 12:49:31 2021 +0100

    browse/release: Add missing SWHIDs info
    
    SWHID links related to reachable revision, directory or content from a
    browsed release were missing in the view.
    
    This fixes the vault cooking task creation for the target directory
    through the use of the "Download" link in the release view.
    
    Closes T2982

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/555/ for more details.

As the changes are in the Python code, shouldn't there be a new (or changed) Python test?

As the changes are in the Python code, shouldn't there be a new (or changed) Python test?

I have updated Python tests to check the new SWHIDs info can be found in produced HTML.

Build is green

Patch application report for D4904 (id=17477)

Rebasing onto e702c28aee...

Current branch diff-target is up to date.
Changes applied before test
commit 8d3bb6f0d329a2edd86c4a8b0e9ea37305b96b7c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jan 21 12:49:31 2021 +0100

    browse/release: Add missing SWHIDs info
    
    SWHID links related to reachable revision, directory or content from a
    browsed release were missing in the view.
    
    This fixes the vault cooking task creation for the target directory
    through the use of the "Download" link in the release view.
    
    Closes T2982

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/557/ for more details.

Build has FAILED

Patch application report for D4904 (id=17479)

Rebasing onto b71d14deeb...

Current branch diff-target is up to date.
Changes applied before test
commit abb5f5a157695125e0047b8932897a7e7d3965ef
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jan 21 12:49:31 2021 +0100

    browse/release: Add missing SWHIDs info
    
    SWHID links related to reachable revision, directory or content from a
    browsed release were missing in the view.
    
    This fixes the vault cooking task creation for the target directory
    through the use of the "Download" link in the release view.
    
    Closes T2982

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/558/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/558/console

Build has FAILED

Patch application report for D4904 (id=17479)

Rebasing onto b71d14deeb...

Current branch diff-target is up to date.
Changes applied before test
commit abb5f5a157695125e0047b8932897a7e7d3965ef
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jan 21 12:49:31 2021 +0100

    browse/release: Add missing SWHIDs info
    
    SWHID links related to reachable revision, directory or content from a
    browsed release were missing in the view.
    
    This fixes the vault cooking task creation for the target directory
    through the use of the "Download" link in the release view.
    
    Closes T2982

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/559/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/559/console

This revision is now accepted and ready to land.Jan 21 2021, 3:53 PM

Build is green

Patch application report for D4904 (id=17479)

Rebasing onto b71d14deeb...

Current branch diff-target is up to date.
Changes applied before test
commit abb5f5a157695125e0047b8932897a7e7d3965ef
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jan 21 12:49:31 2021 +0100

    browse/release: Add missing SWHIDs info
    
    SWHID links related to reachable revision, directory or content from a
    browsed release were missing in the view.
    
    This fixes the vault cooking task creation for the target directory
    through the use of the "Download" link in the release view.
    
    Closes T2982

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/560/ for more details.