Page MenuHomeSoftware Heritage
Differential D4897

Reorganize grab_next_visits tests to better check sorting behavior
ClosedPublic
Actions

Authored by vlorentz on Jan 20 2021, 5:45 PM.

Details

Reviewers
olasd
ardumont
Group Reviewers
Reviewers
Commits
rDSCH03460207a17d: Reorganize grab_next_visits tests to better check sorting behavior
Summary
  • factor out test setup and results checking
  • properly exercize corner cases of the oldest_scheduled_first policy

Depends on D4896

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 20 2021, 5:45 PM
swh-public-ci added a comment.Jan 20 2021, 5:51 PM

Build is green

Patch application report for D4897 (id=17409)

Could not rebase; Attempt merge onto 898820fac5...

Updating 898820f..e031588
Fast-forward
 swh/scheduler/backend.py              | 48 +++++++++++-------
 swh/scheduler/tests/test_scheduler.py | 95 ++++++++++++++++++++++++++---------
 2 files changed, 101 insertions(+), 42 deletions(-)
Changes applied before test
commit e03158823653265bd5ebcb60d7bcc67c0e8beb4e
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jan 20 17:23:03 2021 +0100

    Reorganize grab_next_visits tests to better check sorting behavior
    
     - factor out test setup and results checking
     - properly exercize corner cases of the oldest_scheduled_first policy

commit 8bab1ba37aebbb9921e73ffbb17a9cb25a94c264
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jan 20 17:17:17 2021 +0100

    Make the grab_next_visits sql query modular
    
    This will allow us to easily plug new scheduling policies in that
    function.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/196/ for more details.

Harbormaster completed remote builds in B18546: Diff 17409.Jan 20 2021, 5:51 PM
vlorentz requested review of this revision.Jan 20 2021, 5:51 PM
vlorentz updated this revision to Diff 17455.Jan 21 2021, 11:28 AM

rebase

swh-public-ci added a comment.Jan 21 2021, 11:30 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/211/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/211/console

Harbormaster failed remote builds in B18591: Diff 17455!Jan 21 2021, 11:30 AM
vlorentz updated this revision to Diff 17458.Jan 21 2021, 11:36 AM

rebase

swh-public-ci added a comment.Jan 21 2021, 11:41 AM

Build is green

Patch application report for D4897 (id=17458)

Could not rebase; Attempt merge onto 9fb0dd6c7c...

Updating 9fb0dd6..6ea71f0
Fast-forward
 swh/scheduler/backend.py              |  51 +++++++++++------
 swh/scheduler/tests/test_scheduler.py | 104 +++++++++++++++++++++++++---------
 2 files changed, 109 insertions(+), 46 deletions(-)
Changes applied before test
commit 6ea71f094c81df4d60a5d5872e4b60c2b4dc0f7c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jan 20 17:23:03 2021 +0100

    Reorganize grab_next_visits tests to better check sorting behavior
    
     - factor out test setup and results checking
     - properly exercize corner cases of the oldest_scheduled_first policy

commit b641ac83ebbf0b4d4166034467efa7c591793d50
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jan 20 17:17:17 2021 +0100

    Make the grab_next_visits sql query modular
    
    This will allow us to easily plug new scheduling policies in that
    function.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/214/ for more details.

Harbormaster completed remote builds in B18594: Diff 17458.Jan 21 2021, 11:41 AM
ardumont accepted this revision.Jan 21 2021, 12:06 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/scheduler/tests/test_scheduler.py
828

there are*

This revision is now accepted and ready to land.Jan 21 2021, 12:06 PM
vlorentz updated this revision to Diff 17470.Jan 21 2021, 1:03 PM

black

swh-public-ci added a comment.Jan 21 2021, 1:03 PM

Build has FAILED

Patch application report for D4897 (id=17470)

Rebasing onto af3789891f...

Current branch diff-target is up to date.
Changes applied before test
commit 03460207a17d82635ef5a6f12358392143eb9eef
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jan 20 17:23:03 2021 +0100

    Reorganize grab_next_visits tests to better check sorting behavior
    
     - factor out test setup and results checking
     - properly exercize corner cases of the oldest_scheduled_first policy

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/218/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/218/console

Harbormaster failed remote builds in B18604: Diff 17470!Jan 21 2021, 1:03 PM
swh-public-ci added a comment.Jan 21 2021, 1:08 PM

Build has FAILED

Patch application report for D4897 (id=17470)

Rebasing onto af3789891f...

Current branch diff-target is up to date.
Changes applied before test
commit 03460207a17d82635ef5a6f12358392143eb9eef
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jan 20 17:23:03 2021 +0100

    Reorganize grab_next_visits tests to better check sorting behavior
    
     - factor out test setup and results checking
     - properly exercize corner cases of the oldest_scheduled_first policy

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/221/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/221/console

swh-public-ci added a comment.Jan 21 2021, 1:38 PM

Build is green

Patch application report for D4897 (id=17470)

Rebasing onto af3789891f...

Current branch diff-target is up to date.
Changes applied before test
commit 03460207a17d82635ef5a6f12358392143eb9eef
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jan 20 17:23:03 2021 +0100

    Reorganize grab_next_visits tests to better check sorting behavior
    
     - factor out test setup and results checking
     - properly exercize corner cases of the oldest_scheduled_first policy

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/225/ for more details.

Harbormaster completed remote builds in B18604: Diff 17470.Jan 21 2021, 1:38 PM
Closed by commit rDSCH03460207a17d: Reorganize grab_next_visits tests to better check sorting behavior (authored by olasd, committed by vlorentz). · Explain WhyJan 21 2021, 5:58 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSCH03460207a17d: Reorganize grab_next_visits tests to better check sorting behavior.

Revision Contents
Changeset List

PathSize
swh/
scheduler/
tests/
104 lines

Diff 17487

View Options

swh/scheduler/tests/test_scheduler.py

Loading...
About · Developer information · Legal