Rename test task types to names that match real tasks
ClosedPublic
Actions

Authored by vlorentz on Jan 12 2021, 5:32 PM.

Details

Reviewers

olasd
ardumont

Group Reviewers

Reviewers

Commits

rDSCH3dd1d5f28d32: Rename test task types to names that match real tasks

Summary

The success of tests using these task types would depend on the test run
order, because these task types are (currently) being created by
swh/scheduler/sql/50-data.sql, but the table is truncated after the
first test completes.

Test Plan

*sad trombone* --@olasd

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 12 2021, 5:32 PM

Build is green

Patch application report for D4847 (id=17155)

Could not rebase; Attempt merge onto b13cb1f2de...

Updating b13cb1f..2560e71
Fast-forward
 swh/scheduler/cli/__init__.py          |   7 ++-
 swh/scheduler/cli/origin.py            | 101 +++++++++++++++++++++++++++++++++
 swh/scheduler/tests/common.py          |  10 ++--
 swh/scheduler/tests/test_cli_origin.py |  76 +++++++++++++++++++++++++
 4 files changed, 187 insertions(+), 7 deletions(-)
 create mode 100644 swh/scheduler/cli/origin.py
 create mode 100644 swh/scheduler/tests/test_cli_origin.py

Changes applied before test

commit 2560e71f5b0042b5d508c8ae3d6d580d7098620c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jan 12 17:28:33 2021 +0100

    Rename test task types to names that match real tasks
    
    The success of tests using these task types would depend on the test run
    order, because these task types are (currently) being created by
    swh/scheduler/sql/50-data.sql, but the table is truncated after the
    first test completes.

commit 3c15a60589efdb5268acbe9934e32a5cac2f47a0
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jan 12 16:16:31 2021 +0100

    Introduce a `swh scheduler origin grab-next` cli
    
    This returns, as CSV, the next origins to be visited according to the
    passed scheduling policy.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/98/ for more details.

Harbormaster completed remote builds in B18299: Diff 17155.Jan 12 2021, 5:34 PM

vlorentz requested review of this revision.Jan 12 2021, 5:34 PM

ardumont accepted this revision.Jan 13 2021, 9:50 AM

This revision is now accepted and ready to land.Jan 13 2021, 9:50 AM

rebase

Build is green

Patch application report for D4847 (id=17183)

Could not rebase; Attempt merge onto a62003397d...

Updating a620033..42957c9
Fast-forward
 swh/scheduler/cli/__init__.py          |   7 ++-
 swh/scheduler/cli/origin.py            | 101 +++++++++++++++++++++++++++++++++
 swh/scheduler/tests/common.py          |  10 ++--
 swh/scheduler/tests/test_cli_origin.py |  76 +++++++++++++++++++++++++
 4 files changed, 187 insertions(+), 7 deletions(-)
 create mode 100644 swh/scheduler/cli/origin.py
 create mode 100644 swh/scheduler/tests/test_cli_origin.py

Changes applied before test

commit 42957c9e96e6c7d8070e0b6c786c273e8c1602a0
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jan 12 17:28:33 2021 +0100

    Rename test task types to names that match real tasks
    
    The success of tests using these task types would depend on the test run
    order, because these task types are (currently) being created by
    swh/scheduler/sql/50-data.sql, but the table is truncated after the
    first test completes.

commit d1393c54da99c45175dd0b6a69734d17fc887960
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jan 12 16:16:31 2021 +0100

    Introduce a `swh scheduler origin grab-next` cli
    
    This returns, as CSV, the next origins to be visited according to the
    passed scheduling policy.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/104/ for more details.

Harbormaster completed remote builds in B18327: Diff 17183.Jan 13 2021, 3:46 PM

rebase

Build is green

Patch application report for D4847 (id=17213)

Could not rebase; Attempt merge onto a62003397d...

Updating a620033..3dd1d5f
Fast-forward
 swh/scheduler/cli/__init__.py          |   7 ++-
 swh/scheduler/cli/origin.py            | 102 +++++++++++++++++++++++++++++++++
 swh/scheduler/tests/common.py          |  10 ++--
 swh/scheduler/tests/test_cli_origin.py |  76 ++++++++++++++++++++++++
 4 files changed, 188 insertions(+), 7 deletions(-)
 create mode 100644 swh/scheduler/cli/origin.py
 create mode 100644 swh/scheduler/tests/test_cli_origin.py

Changes applied before test

commit 3dd1d5f28d329620a65ee00749d24401b6d8cf00
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jan 12 17:28:33 2021 +0100

    Rename test task types to names that match real tasks
    
    The success of tests using these task types would depend on the test run
    order, because these task types are (currently) being created by
    swh/scheduler/sql/50-data.sql, but the table is truncated after the
    first test completes.

commit 5d7b002ac403565e348ac8fe4dd56d015cf29cae
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jan 12 16:16:31 2021 +0100

    Introduce a `swh scheduler origin grab-next` cli
    
    This returns, as CSV, the next origins to be visited according to the
    passed scheduling policy.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/117/ for more details.

Harbormaster completed remote builds in B18357: Diff 17213.Jan 14 2021, 1:58 PM

Closed by commit rDSCH3dd1d5f28d32: Rename test task types to names that match real tasks (authored by olasd, committed by vlorentz). · Explain WhyJan 14 2021, 2:16 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSCH3dd1d5f28d32: Rename test task types to names that match real tasks.