Introduce a `swh scheduler origin grab-next` cli
ClosedPublic
Actions

Authored by vlorentz on Jan 12 2021, 4:18 PM.

Details

Reviewers

olasd
anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T2444: Implement the scheduling policy for the recurrent visit scheduler

Commits

rDSCH5d7b002ac403: Introduce a `swh scheduler origin grab-next` cli

Summary

This returns, as CSV, the next origins to be visited according to the
passed scheduling policy.

Test Plan

new tests added

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18326
Build 28304: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 28303: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jan 12 2021, 4:18 PM

Build is green

Patch application report for D4844 (id=17152)

Rebasing onto b13cb1f2de...

Current branch diff-target is up to date.

Changes applied before test

commit 3c15a60589efdb5268acbe9934e32a5cac2f47a0
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jan 12 16:16:31 2021 +0100

    Introduce a `swh scheduler origin grab-next` cli
    
    This returns, as CSV, the next origins to be visited according to the
    passed scheduling policy.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/96/ for more details.

Harbormaster completed remote builds in B18296: Diff 17152.Jan 12 2021, 4:20 PM

vlorentz requested review of this revision.Jan 12 2021, 4:20 PM

vlorentz added a child revision: D4846: Introduce a `swh scheduler origin schedule-next` cli.Jan 12 2021, 5:12 PM

rebase

Build is green

Patch application report for D4844 (id=17182)

Rebasing onto a62003397d...

Current branch diff-target is up to date.

Changes applied before test

commit d1393c54da99c45175dd0b6a69734d17fc887960
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jan 12 16:16:31 2021 +0100

    Introduce a `swh scheduler origin grab-next` cli
    
    This returns, as CSV, the next origins to be visited according to the
    passed scheduling policy.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/103/ for more details.

Harbormaster completed remote builds in B18326: Diff 17182.Jan 13 2021, 3:44 PM

Looks good to me. TIL typing.TYPE_CHECKING.

swh/scheduler/cli/origin.py
5	nitpick: missing line break between license header and import statement.

This revision is now accepted and ready to land.Jan 14 2021, 11:20 AM

add newline

vlorentz marked an inline comment as done.Jan 14 2021, 1:56 PM

Build is green

Patch application report for D4844 (id=17212)

Rebasing onto a62003397d...

Current branch diff-target is up to date.

Changes applied before test

commit 5d7b002ac403565e348ac8fe4dd56d015cf29cae
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jan 12 16:16:31 2021 +0100

    Introduce a `swh scheduler origin grab-next` cli
    
    This returns, as CSV, the next origins to be visited according to the
    passed scheduling policy.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/116/ for more details.

Harbormaster completed remote builds in B18356: Diff 17212.Jan 14 2021, 1:56 PM

Closed by commit rDSCH5d7b002ac403: Introduce a `swh scheduler origin grab-next` cli (authored by olasd, committed by vlorentz). · Explain WhyJan 14 2021, 2:16 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSCH5d7b002ac403: Introduce a `swh scheduler origin grab-next` cli.

olasd added a task: T2444: Implement the scheduling policy for the recurrent visit scheduler.Jan 18 2021, 2:14 PM