client: Fix url to update metadata on deposit with status 'done'
ClosedPublic
Actions

Authored by ardumont on Jan 5 2021, 6:03 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2929: Update deposit through the deposit client no longer works

Commits

rDDEP9ce41a8a91b5: client: Fix url to update metadata on deposit with status 'done'

Summary

Fix regression introduced by the split between the EDIT and SE IRIs:
From PUT /1/swh/37/metadata/ to PUT /1/swh/37/atom/.

This passed unseen as this part is the one part still mocked (justifiably).

Related to T2929

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18181
Build 28063: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 28062: arc lint + arc unit

Event Timeline

ardumont created this revision.Jan 5 2021, 6:03 PM

Build is green

Patch application report for D4808 (id=17040)

Rebasing onto 00d315ec6e...

Current branch diff-target is up to date.

Changes applied before test

commit 9ce41a8a91b56bf352a489453445454cd0bd6af9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jan 5 17:39:18 2021 +0100

    client: Fix url to update metadata on deposit with status 'done'
    
    Related to T2929

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/516/ for more details.

Harbormaster completed remote builds in B18181: Diff 17040.Jan 5 2021, 6:05 PM

ardumont requested review of this revision.Jan 5 2021, 6:05 PM

vlorentz accepted this revision.Jan 5 2021, 6:13 PM

This revision is now accepted and ready to land.Jan 5 2021, 6:13 PM

Closed by commit rDDEP9ce41a8a91b5: client: Fix url to update metadata on deposit with status 'done' (authored by ardumont). · Explain WhyJan 6 2021, 9:34 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEP9ce41a8a91b5: client: Fix url to update metadata on deposit with status 'done'.

ardumont mentioned this in D4817: test_deposit: Fix iri call made by the deposit client.Jan 7 2021, 10:30 AM