Add rsync which is recommended for docker developer setup.
Move comments so that the command is runnable as-is.
Details
Details
- Reviewers
douardda - Group Reviewers
Reviewers - Commits
- rDDOCb8d68f27ece3: developer-setup: update system dependencies
Diff Detail
Diff Detail
- Repository
- rDDOC Development documentation
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Thanks, couple of suggestion.
In general, mention in the diff description the reason of the diff.
That'd be add rsync tool because without it, afair, overriding the default
configuration fail silently when rsync is not installed on the host machine.
Also, that should probably be 3 diffs:
- one to add rsync because reason ^
- one to explicitly mention postgresql-12
- one to format so the command is executable
Cheers,
Comment Actions
because it is unnecessary and is a source for maintenance (need to be updated from time to time)
Comment Actions
because it is unnecessary and is a source for maintenance (need to be updated from time to time)
ok, right.
Also i realized you meant fix as in pin the version...
It got mistranslated in my mind earlier ¯\_(ツ)_/¯ ;)