Details
- Reviewers
douardda ardumont - Group Reviewers
Reviewers - Commits
- rDENVdd20e4f4c158: Data persistence for a devel setting
Diff Detail
- Repository
- rDENV Development environment
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17968 Build 27757: arc lint + arc unit
Event Timeline
docker/README.md | ||
---|---|---|
591 | unused? | |
594 |
This sentence is unnecessary. | |
607 |
this sentense is unclear to me, especially the "like a non-containerized service". Also the "which is not portable" is unclear: what does the "which" refers to? | |
610 |
what does this mean? (also typo in "accesible") | |
612 | Is it really necessary to deal with these permission / ownership stuff? | |
616 | Note that using named volumes in docker-compose.yml (without making them external or bind-mounts of an existing directory) also make them resilient on docker-compose down (unless called with --volumes) So IMHO this section could be simplified substancially, and I'd prefer the volumes declarations examples to be given as docker-compose override files rather than suggesting to modify the git-managed docker-compose.yml file. |
docker/README.md | ||
---|---|---|
594 | Agreed. Also it'd be neat to pinpoint what's not clear in those other documentations to disambiguate them ;) |
docker/README.md | ||
---|---|---|
612 | Multiples resources online do it, probably not a good solution. After some more tests, it seems not necessary in my setup. Ownership and permissions on the bind mount are updated by the container. | |
616 | About volumes: About the override: |
docker/README.md | ||
---|---|---|
591 | Yes, unused is one of the terms used in the documentation. | |
607 | Is it better? |
docker/README.md | ||
---|---|---|
594 | I hesitated to write it in the first place, but thought it was important to mention. See supra link to the doc. Removed. Indeed too generic. |
docker/README.md | ||
---|---|---|
591 | According to the doc you are mentioning: Networks and volumes defined as external are never removed. So it might be enough to find the way to declare volumes as external That's what I deduce from that documentation sentence, |
docker/README.md | ||
---|---|---|
591 | ah sorry, i just reread between the discussion comments, that's what you are doing below... neat. |
docker/README.md | ||
---|---|---|
614 | persist |