requirement: Adapt celery requirements
ClosedPublic
Actions

Authored by ardumont on Dec 7 2020, 9:12 AM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDSCHebff12ba1e97: requirement: Adapt celery requirements

Summary

This adapts the celery requirements to the last known where our builds are
fine. Currently, 5.0.3 got released and this ends up making all the swh modules
relying on tasks timeout. A bug upstream is opened [1].

In the mean time, this workaround fixes [2] and most probably the remaining swh
builds.

[1] https://github.com/celery/celery/issues/6521

[2] https://jenkins.softwareheritage.org/job/DSCH/job/tests/1132/console

Test Plan

tox

Another test on current failing build (swh-indexer):

(swh-indexer) $ .tox/py3/bin/pip install ../swh-scheduler
(swh-indexer) $ tox -- -x -s
...
330 passed, 15 skipped, 1 warning in 56.79s

-- summary --

  black: commands succeeded
  flake8: commands succeeded
  mypy: commands succeeded
  py3: commands succeeded
  congratulations :)

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 7 2020, 9:12 AM

Build is green

Patch application report for D4672 (id=16575)

Rebasing onto 3c8707599a...

Current branch diff-target is up to date.

Changes applied before test

commit 13a93959911385c50653ff0985a0497aab380c1b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Dec 7 09:10:34 2020 +0100

    requirement: Adapt celery requirements to the last known version ok
    
    For our builds to pass
    
    This fixes [1] and most probably unstuck our remaining swh builds.
    
    [1] https://jenkins.softwareheritage.org/job/DSCH/job/tests/1132/console

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/83/ for more details.

Harbormaster completed remote builds in B17757: Diff 16575.Dec 7 2020, 9:14 AM

ardumont edited the test plan for this revision. (Show Details)Dec 7 2020, 9:25 AM

Could you make this celery >= 4.3, != 5.0.3 instead? looks like the upstream fix is going to arrive soon...

Could you make this celery >= 4.3, != 5.0.3 instead? looks like the upstream fix is going to arrive soon...

sure

Adapt according to suggestion

ardumont retitled this revision from requirement: Adapt celery requirements to the last known version ok to requirement: Adapt celery requirements.Dec 7 2020, 9:32 AM

ardumont edited the summary of this revision. (Show Details)

Build is green

Patch application report for D4672 (id=16576)

Rebasing onto 3c8707599a...

Current branch diff-target is up to date.

Changes applied before test

commit ebff12ba1e97dbaa29fcdeb4ddcd18167ed8678f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Dec 7 09:10:34 2020 +0100

    requirement: Adapt celery requirements
    
    This adapts the celery requirements to the last known where our builds are
    fine. Currently, 5.0.3 got released and this ends up making all the swh modules
    relying on tasks timeout. A bug upstream is opened [1].
    
    In the mean time, this workaround fixes [2] and most probably the remaining swh
    builds.
    
    [1] https://github.com/celery/celery/issues/6521
    
    [2] https://jenkins.softwareheritage.org/job/DSCH/job/tests/1132/console

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/84/ for more details.

Harbormaster completed remote builds in B17758: Diff 16576.Dec 7 2020, 9:33 AM

olasd accepted this revision.Dec 7 2020, 9:34 AM

This revision is now accepted and ready to land.Dec 7 2020, 9:34 AM

Closed by commit rDSCHebff12ba1e97: requirement: Adapt celery requirements (authored by ardumont). · Explain WhyDec 7 2020, 9:40 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSCHebff12ba1e97: requirement: Adapt celery requirements.