Differential D4666

staging: Deploy swh-search rpc backend on search0
ClosedPublic
Actions

Authored by ardumont on Dec 4 2020, 4:13 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

System administrators

Maniphest Tasks

T2817: Enable the swh-search environment in staging

Commits

rSPSITEcd37882b8053: staging: Deploy swh-search rpc backend on search0

Summary

Related to T2817

Test Plan

vagrant up staging-search0 happy

Diff Detail

Repository

rSPSITE puppet-swh-site

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 4 2020, 4:13 PM

Harbormaster completed remote builds in B17747: Diff 16564.Dec 4 2020, 4:13 PM

ardumont edited the summary of this revision. (Show Details)Dec 4 2020, 4:54 PM

ardumont edited the summary of this revision. (Show Details)

ardumont added a task: T2817: Enable the swh-search environment in staging.

ardumont added a child revision: D4668: Add swh-search-journal-client to swh_search_with_journal_client role.Dec 4 2020, 7:29 PM

anlambert added a subscriber: anlambert.Dec 5 2020, 2:55 AM

anlambert added inline comments.

data/deployments/staging/common.yaml
270	The webapp can query elasticsearch to get some info related to scheduler tasks associated to save code now requests https://forge.softwareheritage.org/source/swh-web/browse/master/swh/web/common/origin_save.py$505 That line is webapp specific config so I do not think it is at the the right place ;-)

ardumont added inline comments.Dec 7 2020, 6:36 PM

data/deployments/staging/common.yaml
270	The webapp can query elasticsearch to get some info related to scheduler tasks associated to save code now requests https://forge.softwareheritage.org/source/swh-web/browse/master/swh/web/common/origin_save.py$505 Thanks, I completely forgot about that ;) That line is webapp specific config so I do not think it is at the the right place ;-) Right. We are pondering whether we should move those tasks in the new dedicated cluster outside of the logging cluster (the production one is a logging cluster mostly, it just so happens we have origins and tasks related thrown in the mix as well). Also there is the consideration that the scheduler db will at some point migrate to a new schema (current refactoring on scheduler/lister). That actually means the tasks won't stay in their current form (or something...)

ardumont retitled this revision from wip: staging: Deploy swh-search rpc backend on search0 to staging: Deploy swh-search rpc backend on search0.Dec 7 2020, 6:37 PM

As discussed together, we will need several instances of the journal to be able to use different prefixes.
It should be managed by puppet to

This revision now requires changes to proceed.Dec 8 2020, 11:17 AM

My previous comment was not for this diff but for D4668 :)

This revision is now accepted and ready to land.Dec 8 2020, 11:31 AM

squash commits together
Rework comment message

Harbormaster completed remote builds in B17795: Diff 16616.Dec 8 2020, 12:01 PM

Closed by commit rSPSITEcd37882b8053: staging: Deploy swh-search rpc backend on search0 (authored by ardumont). · Explain WhyDec 8 2020, 12:17 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rSPSITEcd37882b8053: staging: Deploy swh-search rpc backend on search0.

Revision Contents
Changeset List

Path

Size

data/

deployments/

staging/

14 lines

subnets/

2 lines

manifests/

4 lines

site-modules/

role/

manifests/

3 lines

Diff 16619

data/deployments/staging/common.yaml

Loading...

data/subnets/vagrant.yaml

Loading...

manifests/site.pp

Loading...

site-modules/role/manifests/swh_search.pp

Loading...