Differential D4659

browse: Simplify metadata popup and hide toggle button when not needed
ClosedPublic
Actions

Authored by anlambert on Dec 3 2020, 7:24 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2848: web app: use SWHIDs everywhere in metadata view

Commits

rDWAPPS1eebe9e1146e: browse: Simplify metadata popup and hide toggle button when not needed

Summary

Rework the content of the popup than can be shown when clicking on the
"Show metadata" button by only displaying raw metadata associated to a
swh object.

As only revision objects can have raw metadata associated, hide the toggle
button in views dedicated to browse other object types. The button will
also be hidden if revision metdata are empty.

Closes T2848

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Dec 3 2020, 7:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 3 2020, 7:24 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/516/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/516/console

Harbormaster failed remote builds in B17720: Diff 16533!Dec 3 2020, 7:26 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/517/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/517/console

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/518/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/518/console

Build is green

Patch application report for D4659 (id=16533)

Rebasing onto ff0cc3631a...

Current branch diff-target is up to date.

Changes applied before test

commit d7ad527b225962a7072684088ec0b2576201f47f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Dec 3 19:17:42 2020 +0100

    browse: Simplify metadata popup and hide toggle button when not needed
    
    Rework the content of the popup than can be shown when clicking on the
    "Show metadata" button by only displaying raw metadata associated to a
    swh object.
    
    As only revision objects can have raw metadata associated, hide the toggle
    button in views dedicated to browse other object types. The button will
    also be hidden if revision metdata are empty.
    
    Closes T2848

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/519/ for more details.

Harbormaster completed remote builds in B17720: Diff 16533.Dec 4 2020, 11:21 AM

vlorentz accepted this revision.Dec 4 2020, 11:29 AM

This revision is now accepted and ready to land.Dec 4 2020, 11:29 AM

Update: Rebase and remove no more needed generation of HTML links in SWH objects metadata (not displayed anymore).

Build is green

Patch application report for D4659 (id=16558)

Rebasing onto ececc29101...

Current branch diff-target is up to date.

Changes applied before test

commit 1eebe9e1146e54ea4fd2806b488068f42423742c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Dec 3 19:17:42 2020 +0100

    browse: Simplify metadata popup and hide toggle button when not needed
    
    Rework the content of the popup than can be shown when clicking on the
    "Show metadata" button by only displaying raw metadata associated to a
    swh object.
    
    As only revision objects can have raw metadata associated, hide the toggle
    button in views dedicated to browse other object types. The button will
    also be hidden if revision metdata are empty.
    
    Closes T2848

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/520/ for more details.

Harbormaster completed remote builds in B17741: Diff 16558.Dec 4 2020, 2:42 PM

Closed by commit rDWAPPS1eebe9e1146e: browse: Simplify metadata popup and hide toggle button when not needed (authored by anlambert). · Explain WhyDec 4 2020, 2:46 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS1eebe9e1146e: browse: Simplify metadata popup and hide toggle button when not needed.