Page MenuHomeSoftware Heritage

browse: Simplify metadata popup and hide toggle button when not needed
ClosedPublic

Authored by anlambert on Dec 3 2020, 7:24 PM.

Details

Summary

Rework the content of the popup than can be shown when clicking on the
"Show metadata" button by only displaying raw metadata associated to a
swh object.

As only revision objects can have raw metadata associated, hide the toggle
button in views dedicated to browse other object types. The button will
also be hidden if revision metdata are empty.

Closes T2848

Diff Detail

Repository
rDWAPPS Web applications
Branch
metadata-popup-simplify
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17720
Build 27394: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 27393: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4659 (id=16533)

Rebasing onto ff0cc3631a...

Current branch diff-target is up to date.
Changes applied before test
commit d7ad527b225962a7072684088ec0b2576201f47f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Dec 3 19:17:42 2020 +0100

    browse: Simplify metadata popup and hide toggle button when not needed
    
    Rework the content of the popup than can be shown when clicking on the
    "Show metadata" button by only displaying raw metadata associated to a
    swh object.
    
    As only revision objects can have raw metadata associated, hide the toggle
    button in views dedicated to browse other object types. The button will
    also be hidden if revision metdata are empty.
    
    Closes T2848

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/519/ for more details.

This revision is now accepted and ready to land.Dec 4 2020, 11:29 AM

Update: Rebase and remove no more needed generation of HTML links in SWH objects metadata (not displayed anymore).

Build is green

Patch application report for D4659 (id=16558)

Rebasing onto ececc29101...

Current branch diff-target is up to date.
Changes applied before test
commit 1eebe9e1146e54ea4fd2806b488068f42423742c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Dec 3 19:17:42 2020 +0100

    browse: Simplify metadata popup and hide toggle button when not needed
    
    Rework the content of the popup than can be shown when clicking on the
    "Show metadata" button by only displaying raw metadata associated to a
    swh object.
    
    As only revision objects can have raw metadata associated, hide the toggle
    button in views dedicated to browse other object types. The button will
    also be hidden if revision metdata are empty.
    
    Closes T2848

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/520/ for more details.