Differential D4605

indexer.journal_client: Subscribe to OriginVisitStatus topic
ClosedPublic
Actions

Authored by ardumont on Nov 26 2020, 3:17 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2814: Fix swh indexer journal client service

Commits

rDCIDX7e03cc687c00: indexer.journal_client: Subscribe to OriginVisitStatus topic

Summary

... instead of OriginVisit.

OriginVisit model object no longer hold status information so the current
filtering happening on the journal client side could not work.

Related to T2814
Related to P882

Test Plan

tox

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 26 2020, 3:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 26 2020, 3:17 PM

Build is green

Patch application report for D4605 (id=16347)

Rebasing onto d92c241980...

Current branch diff-target is up to date.

Changes applied before test

commit 7e03cc687c00b44cb7fbd76467566ad2de52eed1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Nov 26 15:12:55 2020 +0100

    indexer.journal_client: Subscribe to OriginVisitStatus topic
    
    ... instead of OriginVisit.
    
    OriginVisit model object no longer hold status information so the current
    filtering happening on the journal client side could not work.
    
    Related to T2814
    Related to P882

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/124/ for more details.

ardumont mentioned this in T2814: Fix swh indexer journal client service.Nov 26 2020, 3:20 PM

Harbormaster completed remote builds in B17540: Diff 16347.Nov 26 2020, 3:20 PM

ardumont mentioned this in D4599: swh.indexer.cli.journal_client: fix config use.Nov 26 2020, 3:22 PM

vlorentz accepted this revision.Nov 26 2020, 4:05 PM

This revision is now accepted and ready to land.Nov 26 2020, 4:05 PM

Closed by commit rDCIDX7e03cc687c00: indexer.journal_client: Subscribe to OriginVisitStatus topic (authored by ardumont). · Explain WhyNov 26 2020, 4:58 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDX7e03cc687c00: indexer.journal_client: Subscribe to OriginVisitStatus topic.

Do these tests actually match the current contents of the origin_visit_status topic? I find this a little dubious.