Updating 5c915825..8c864c4d
Fast-forward
 swh/web/api/utils.py                      |   8 +-
 swh/web/api/views/directory.py            |   4 +-
 swh/web/api/views/revision.py             |  50 +++-------
 swh/web/tests/api/test_utils.py           |   8 +-
 swh/web/tests/api/views/test_directory.py |  10 +-
 swh/web/tests/api/views/test_revision.py  | 146 ++++++++++++++----------------
 6 files changed, 98 insertions(+), 128 deletions(-)

Changes applied before test

commit 8c864c4dd69fa91497bba4d67ace167179cd4f1f
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Nov 23 19:02:26 2020 +0100

    api/revision: Fix /revision/directory endpoint and improve tests
    
    That endpoint was currently returning an error 500 as some breaking changes
    were missed due to the use of mocking in tests.
    
    So fix the issue and ensure asociated tests do not use any mocks anymore.

commit f5b8445c361ca7ed38c379270ba6f4c85957fdc1
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Nov 23 17:36:30 2020 +0100

    api/utils: Rename enrich_directory to enrich_directory_entry
    
    That function only processes a single directory entry so rename it.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/490/ for more details.

Harbormaster completed remote builds in B17422: Diff 16223.Nov 23 2020, 7:20 PM

vlorentz accepted this revision.Nov 24 2020, 11:47 AM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/web/api/views/revision.py
150–151	not covered, btw

This revision is now accepted and ready to land.Nov 24 2020, 11:47 AM

Update: Add missing test for revision dir entry

Build is green

Patch application report for D4567 (id=16242)

Could not rebase; Attempt merge onto 5c915825bd...

Updating 5c915825..b7cb525f
Fast-forward
 swh/web/api/utils.py                      |   8 +-
 swh/web/api/views/directory.py            |   4 +-
 swh/web/api/views/revision.py             |  50 +++------
 swh/web/tests/api/test_utils.py           |   8 +-
 swh/web/tests/api/views/test_directory.py |  10 +-
 swh/web/tests/api/views/test_revision.py  | 180 ++++++++++++++++++------------
 6 files changed, 137 insertions(+), 123 deletions(-)

Changes applied before test

commit b7cb525fda0ca8964f65021ba41338dc358552e7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Nov 23 19:02:26 2020 +0100

    api/revision: Fix /revision/directory endpoint and improve tests
    
    That endpoint was currently returning an error 500 as some breaking changes
    were missed due to the use of mocking in tests.
    
    So fix the issue and ensure asociated tests do not use any mocks anymore.

commit f5b8445c361ca7ed38c379270ba6f4c85957fdc1
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Nov 23 17:36:30 2020 +0100

    api/utils: Rename enrich_directory to enrich_directory_entry
    
    That function only processes a single directory entry so rename it.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/493/ for more details.

Harbormaster completed remote builds in B17435: Diff 16242.Nov 24 2020, 12:18 PM

Closed by commit rDWAPPSb7cb525fda0c: api/revision: Fix /revision/directory endpoint and improve tests (authored by anlambert). · Explain WhyNov 24 2020, 12:19 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSb7cb525fda0c: api/revision: Fix /revision/directory endpoint and improve tests.