backfill: Reverse flawed logic in SnapshotBranch generation
ClosedPublic
Actions

Authored by olasd on Nov 13 2020, 4:53 PM.

Details

Reviewers

vlorentz
ardumont

Commits

rDSTO0065d4df136f: backfill: Reverse flawed logic in SnapshotBranch generation

Summary

The previous code would nullify all non-null branches, and try to create a
SnapshotBranch out of null branches.

Test Plan

noticed the bug in production; the tests that perform a comparison of
in-memory storage contents now only test these the data superficially and need
to be improved.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Nov 13 2020, 4:53 PM

Build is green

Patch application report for D4473 (id=15877)

Rebasing onto f5011362fb...

Current branch diff-target is up to date.

Changes applied before test

commit 0065d4df136f5898bc780810d1834626cabbfde8
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Nov 13 16:50:18 2020 +0100

    backfill: Reverse flawed logic in SnapshotBranch generation
    
    The previous code would nullify all non-null branches, and try to create a
    SnapshotBranch out of null branches.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1068/ for more details.

Harbormaster completed remote builds in B17088: Diff 15877.Nov 13 2020, 4:58 PM

ardumont accepted this revision.Nov 13 2020, 5:11 PM

This revision is now accepted and ready to land.Nov 13 2020, 5:11 PM

Closed by commit rDSTO0065d4df136f: backfill: Reverse flawed logic in SnapshotBranch generation (authored by olasd). · Explain WhyNov 16 2020, 2:20 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO0065d4df136f: backfill: Reverse flawed logic in SnapshotBranch generation.