Page MenuHomeSoftware Heritage
Differential D4472

assets: Migrate compilation to webpack 5.x
ClosedPublic
Actions

Authored by anlambert on Nov 13 2020, 4:23 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS660ef62fd64b: assets: Migrate compilation to webpack 5.x
rDWAPPSaa969353e155: package.json: Upgrade dependencies
Summary

Migrate to the latest major version of webpack module bundler released a
couple of weeks ago.

Apart a couple of workarounds related to webpack-dev-server, the migration
mainly consists in updating some configuration, porting swh webpack plugins
to the 5.x API and fixing some new compilation warnings.

Depends on D4474

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Nov 13 2020, 4:23 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 13 2020, 4:23 PM
swh-public-ci added a comment.Nov 13 2020, 4:26 PM

Build has FAILED

Patch application report for D4472 (id=15875)

Rebasing onto f5469a4a16...

Current branch diff-target is up to date.
Changes applied before test
commit 752aca2d0c1a41c77410759d660322cd60e9f956
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Oct 30 16:51:16 2020 +0100

    assets: Migrate compilation to webpack 5.x
    
    Migrate to the latest major version of webpack module bundler released a
    couple of weeks ago.
    
    Apart a couple of workarounds related to webpack-dev-server, the migration
    mainly consists in updating some configuration, porting swh webpack plugins
    to the 5.x API and fixing some new compilation warnings.

commit 0c80e35e51bd2dc9b19bff3f65f314b5d9e11c80
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Nov 13 14:07:51 2020 +0100

    package.json: Upgrade dependencies

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/468/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/468/console

Harbormaster failed remote builds in B17086: Diff 15875!Nov 13 2020, 4:26 PM
anlambert mentioned this in D4474: templates/stage-cypress-tests: Simplify environment setup script.Nov 13 2020, 4:58 PM
anlambert edited the summary of this revision. (Show Details)Nov 13 2020, 4:59 PM
anlambert added a parent revision: D4474: templates/stage-cypress-tests: Simplify environment setup script.
In D4472#111678, @swh-public-ci wrote:

Build has FAILED

Patch application report for D4472 (id=15875)

Rebasing onto f5469a4a16...

Current branch diff-target is up to date.
Changes applied before test
commit 752aca2d0c1a41c77410759d660322cd60e9f956
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Oct 30 16:51:16 2020 +0100

    assets: Migrate compilation to webpack 5.x
    
    Migrate to the latest major version of webpack module bundler released a
    couple of weeks ago.
    
    Apart a couple of workarounds related to webpack-dev-server, the migration
    mainly consists in updating some configuration, porting swh webpack plugins
    to the 5.x API and fixing some new compilation warnings.

commit 0c80e35e51bd2dc9b19bff3f65f314b5d9e11c80
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Nov 13 14:07:51 2020 +0100

    package.json: Upgrade dependencies

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/468/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/468/console

Build will be fixed once D4474 gets landed.

swh-public-ci added a comment.Nov 13 2020, 5:30 PM

Build is green

Patch application report for D4472 (id=15875)

Rebasing onto f5469a4a16...

Current branch diff-target is up to date.
Changes applied before test
commit 752aca2d0c1a41c77410759d660322cd60e9f956
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Oct 30 16:51:16 2020 +0100

    assets: Migrate compilation to webpack 5.x
    
    Migrate to the latest major version of webpack module bundler released a
    couple of weeks ago.
    
    Apart a couple of workarounds related to webpack-dev-server, the migration
    mainly consists in updating some configuration, porting swh webpack plugins
    to the 5.x API and fixing some new compilation warnings.

commit 0c80e35e51bd2dc9b19bff3f65f314b5d9e11c80
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Nov 13 14:07:51 2020 +0100

    package.json: Upgrade dependencies

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/469/ for more details.

Harbormaster completed remote builds in B17086: Diff 15875.Nov 13 2020, 5:30 PM
vlorentz added a subscriber: vlorentz.Nov 17 2020, 11:27 AM

That's a lot of workarounds... Don't we want to wait for Webpack to iron these out?

anlambert added a comment.Nov 18 2020, 11:27 AM
In D4472#112002, @vlorentz wrote:

That's a lot of workarounds... Don't we want to wait for Webpack to iron these out?

The workarounds are mainly for webpack plugins not for the core software, thus issues might be longer to be fixed upstream.

I will keep an eye on the associated issues and and remove them once they are resolved upstream.

Latest webpack release brings nice improvements so we should upgrade to it.

vlorentz accepted this revision.Nov 18 2020, 11:37 AM
This revision is now accepted and ready to land.Nov 18 2020, 11:37 AM
anlambert updated this revision to Diff 15963.Nov 18 2020, 12:07 PM

Rebase

swh-public-ci added a comment.Nov 18 2020, 12:13 PM

Build is green

Patch application report for D4472 (id=15963)

Rebasing onto 8a0f32d124...

Current branch diff-target is up to date.
Changes applied before test
commit 660ef62fd64b5322781d9c9c3df6660a63edf017
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Oct 30 16:51:16 2020 +0100

    assets: Migrate compilation to webpack 5.x
    
    Migrate to the latest major version of webpack module bundler released a
    couple of weeks ago.
    
    Apart a couple of workarounds related to webpack-dev-server, the migration
    mainly consists in updating some configuration, porting swh webpack plugins
    to the 5.x API and fixing some new compilation warnings.

commit aa969353e155b939f0a64646177c8bb55c3c630e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Nov 13 14:07:51 2020 +0100

    package.json: Upgrade dependencies

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/475/ for more details.

Harbormaster completed remote builds in B17168: Diff 15963.Nov 18 2020, 12:13 PM
Closed by commit rDWAPPSaa969353e155: package.json: Upgrade dependencies (authored by anlambert). · Explain WhyNov 18 2020, 12:17 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSaa969353e155: package.json: Upgrade dependencies.
anlambert added a commit: rDWAPPS660ef62fd64b: assets: Migrate compilation to webpack 5.x.

Revision Contents
Changeset List

PathSize
24 lines
221 lines

Diff 15967

View Options

package.json

Loading...
View Options

yarn.lock

Loading...
About · Developer information · Legal