Differential D4457

test: Migrate parse_swhid test cases to pytest
ClosedPublic
Actions

Authored by ardumont on Nov 10 2020, 4:13 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2769: Make function swh.model.identifiers.parse_swhid more strict

Commits

rDMOD47946aac0220: test: Migrate parse_swhid test cases to pytest

Summary

First step prior to rework the error messages and add more strictness
to the parse_swhid function.

Related to T2769

Test Plan

tox

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17010
Build 26249: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 26248: arc lint + arc unit

Event Timeline

ardumont created this revision.Nov 10 2020, 4:13 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 10 2020, 4:13 PM

Build is green

Patch application report for D4457 (id=15800)

Rebasing onto 4e3fdc062c...

Current branch diff-target is up to date.

Changes applied before test

commit 355dd50aa0b98ff904f73c37d7b38472ca41198a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Nov 10 16:11:32 2020 +0100

    test: Check the detailed error message when swhid is invalid
    
    Related to T2769

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/161/ for more details.

Harbormaster completed remote builds in B17010: Diff 15800.Nov 10 2020, 4:15 PM

Drop the string check assertions part

ardumont retitled this revision from test: Check the detailed error message when swhid is invalid to test: Migrate parse_swhid test cases to pytest.Nov 10 2020, 6:37 PM

ardumont edited the summary of this revision. (Show Details)

ardumont edited the test plan for this revision. (Show Details)

Build is green

Patch application report for D4457 (id=15805)

Rebasing onto 4e3fdc062c...

Current branch diff-target is up to date.

Changes applied before test

commit 47946aac0220fcfd55c7998908c71a6f402a5ddb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Nov 10 16:11:32 2020 +0100

    test: Migrate parse_swhid test cases to pytest
    
    Related to T2769

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/163/ for more details.

Harbormaster completed remote builds in B17015: Diff 15805.Nov 10 2020, 6:38 PM

ardumont added a child revision: D4458: model.identifiers: Improve error messages in case of invalid SWHIDs.Nov 12 2020, 10:17 AM

vlorentz accepted this revision.Nov 12 2020, 11:17 AM

This revision is now accepted and ready to land.Nov 12 2020, 11:17 AM

Closed by commit rDMOD47946aac0220: test: Migrate parse_swhid test cases to pytest (authored by ardumont). · Explain WhyNov 12 2020, 11:38 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDMOD47946aac0220: test: Migrate parse_swhid test cases to pytest.