Page MenuHomeSoftware Heritage

test: Migrate parse_swhid test cases to pytest
ClosedPublic

Authored by ardumont on Tue, Nov 10, 4:13 PM.

Details

Summary

First step prior to rework the error messages and add more strictness
to the parse_swhid function.

Related to T2769

Test Plan

tox

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Tue, Nov 10, 4:13 PM

Build is green

Patch application report for D4457 (id=15800)

Rebasing onto 4e3fdc062c...

Current branch diff-target is up to date.
Changes applied before test
commit 355dd50aa0b98ff904f73c37d7b38472ca41198a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Nov 10 16:11:32 2020 +0100

    test: Check the detailed error message when swhid is invalid
    
    Related to T2769

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/161/ for more details.

ardumont updated this revision to Diff 15805.Tue, Nov 10, 6:37 PM

Drop the string check assertions part

ardumont retitled this revision from test: Check the detailed error message when swhid is invalid to test: Migrate parse_swhid test cases to pytest.Tue, Nov 10, 6:37 PM
ardumont edited the summary of this revision. (Show Details)
ardumont edited the test plan for this revision. (Show Details)

Build is green

Patch application report for D4457 (id=15805)

Rebasing onto 4e3fdc062c...

Current branch diff-target is up to date.
Changes applied before test
commit 47946aac0220fcfd55c7998908c71a6f402a5ddb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Nov 10 16:11:32 2020 +0100

    test: Migrate parse_swhid test cases to pytest
    
    Related to T2769

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/163/ for more details.

vlorentz accepted this revision.Thu, Nov 12, 11:17 AM
This revision is now accepted and ready to land.Thu, Nov 12, 11:17 AM
This revision was automatically updated to reflect the committed changes.