Page MenuHomeSoftware Heritage

test_origin_intrinsic_metadata_add__deadlock: use more values, to make the test less likely to unexpectedly pass.
ClosedPublic

Authored by vlorentz on Nov 5 2020, 1:39 PM.

Details

Test Plan

Depends on D4417 or it will fail... most of the time :)

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D4418 (id=15655)

Could not rebase; Attempt merge onto e2835bfff6...

Updating e2835bf..8272bc9
Fast-forward
 swh/indexer/tests/storage/test_storage.py | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
Changes applied before test
commit 8272bc90a367f2d9a9eb231505ad3ccc126c714f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 5 13:36:44 2020 +0100

    test_origin_intrinsic_metadata_add__deadlock: use more values, to make the test less likely to unexpectedly pass.

commit 5a5af91ac5aee172ff58e68f8b2121de179635e9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 5 13:37:43 2020 +0100

    test_origin_intrinsic_metadata_add__deadlock: Fix failure on nondeterministic order
    
    postgresql kindly returns the results in the order the test expected... most of the time.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/113/ for more details.

This revision is now accepted and ready to land.Nov 5 2020, 2:00 PM