Differential D4417

test_origin_intrinsic_metadata_add__deadlock: Fix failure on nondeterministic order
ClosedPublic
Actions

Authored by vlorentz on Nov 5 2020, 1:38 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCIDX5a5af91ac5ae: test_origin_intrinsic_metadata_add__deadlock: Fix failure on nondeterministic…

Summary

postgresql kindly returns the results in the order the test expected... most of the time.

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 5 2020, 1:38 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 5 2020, 1:38 PM

vlorentz added a child revision: D4418: test_origin_intrinsic_metadata_add__deadlock: use more values, to make the test less likely to unexpectedly pass..Nov 5 2020, 1:39 PM

Build is green

Patch application report for D4417 (id=15654)

Rebasing onto e2835bfff6...

Current branch diff-target is up to date.

Changes applied before test

commit 5a5af91ac5aee172ff58e68f8b2121de179635e9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 5 13:37:43 2020 +0100

    test_origin_intrinsic_metadata_add__deadlock: Fix failure on nondeterministic order
    
    postgresql kindly returns the results in the order the test expected... most of the time.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/112/ for more details.

Harbormaster completed remote builds in B16876: Diff 15654.Nov 5 2020, 1:40 PM

ardumont accepted this revision.Nov 5 2020, 2:00 PM

This revision is now accepted and ready to land.Nov 5 2020, 2:00 PM

Closed by commit rDCIDX5a5af91ac5ae: test_origin_intrinsic_metadata_add__deadlock: Fix failure on nondeterministic… (authored by vlorentz). · Explain WhyNov 6 2020, 12:28 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDX5a5af91ac5ae: test_origin_intrinsic_metadata_add__deadlock: Fix failure on nondeterministic….