Differential D4401

Remove conflict_update/policy_update option from BaseIndexer.run()
ClosedPublic
Actions

Authored by vlorentz on Nov 3 2020, 2:26 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCIDX8e69633f639e: Remove conflict_update/policy_update option from BaseIndexer.run()

Summary

By removing the False/ignore-dups behavior, which we didn't use.

The main motivation is to make _add endpoints write to Kafka in a
future commit, as Kafka's semantics are closer to True/update-dups
than False/ignore-dups.

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 3 2020, 2:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 3 2020, 2:26 PM

vlorentz mentioned this in D4397: Remove conflict_update/policy_update option..Nov 3 2020, 2:27 PM

vlorentz added a child revision: D4400: Remove conflict_update option from _add() endpoints..

Build is green

Patch application report for D4401 (id=15589)

Rebasing onto 94c8259193...

Current branch diff-target is up to date.

Changes applied before test

commit 8e69633f639e31cf5efa3edd784397b351d3b2db
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 3 14:19:23 2020 +0100

    Remove conflict_update/policy_update option from BaseIndexer.run()
    
    By removing the False/ignore-dups behavior, which we didn't use.
    
    The main motivation is to make _add endpoints write to Kafka in a
    future commit, as Kafka's semantics are closer to True/update-dups
    than False/ignore-dups.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/109/ for more details.

Harbormaster completed remote builds in B16812: Diff 15589.Nov 3 2020, 2:28 PM

ardumont accepted this revision.Nov 3 2020, 2:34 PM

This revision is now accepted and ready to land.Nov 3 2020, 2:34 PM

Closed by commit rDCIDX8e69633f639e: Remove conflict_update/policy_update option from BaseIndexer.run() (authored by vlorentz). · Explain WhyNov 3 2020, 5:03 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDX8e69633f639e: Remove conflict_update/policy_update option from BaseIndexer.run().