Page MenuHomeSoftware Heritage

Remove conflict_update/policy_update option from BaseIndexer.run()
ClosedPublic

Authored by vlorentz on Nov 3 2020, 2:26 PM.

Details

Summary

By removing the False/ignore-dups behavior, which we didn't use.

The main motivation is to make _add endpoints write to Kafka in a
future commit, as Kafka's semantics are closer to True/update-dups
than False/ignore-dups.

Diff Detail

Event Timeline

Build is green

Patch application report for D4401 (id=15589)

Rebasing onto 94c8259193...

Current branch diff-target is up to date.
Changes applied before test
commit 8e69633f639e31cf5efa3edd784397b351d3b2db
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Nov 3 14:19:23 2020 +0100

    Remove conflict_update/policy_update option from BaseIndexer.run()
    
    By removing the False/ignore-dups behavior, which we didn't use.
    
    The main motivation is to make _add endpoints write to Kafka in a
    future commit, as Kafka's semantics are closer to True/update-dups
    than False/ignore-dups.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/109/ for more details.

This revision is now accepted and ready to land.Nov 3 2020, 2:34 PM