Replace RawExtrinsicMetadata `id` attribute with `target`.
ClosedPublic
Actions

Authored by olasd on Oct 27 2020, 1:31 PM.

Details

Reviewers

ardumont
vlorentz

Commits

rDDEP3b8f33876f84: Replace RawExtrinsicMetadata `id` attribute with `target`.

Summary

The old attribute was deprecated in swh.model 0.7.2

Test Plan

tox throws fewer deprecation warnings

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 27 2020, 1:31 PM

Build is green

Patch application report for D4361 (id=15423)

Rebasing onto 021236dcbb...

Current branch diff-target is up to date.

Changes applied before test

commit 3b8f33876f8476286deccca3c16f1819447c2d2f
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Oct 27 13:25:40 2020 +0100

    Replace RawExtrinsicMetadata `id` attribute with `target`.
    
    The old attribute was deprecated in swh.model 0.7.2

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/269/ for more details.

Harbormaster completed remote builds in B16650: Diff 15423.Oct 27 2020, 1:34 PM

ardumont accepted this revision.Oct 27 2020, 4:10 PM

This revision is now accepted and ready to land.Oct 27 2020, 4:10 PM

Closed by commit rDDEP3b8f33876f84: Replace RawExtrinsicMetadata `id` attribute with `target`. (authored by olasd). · Explain WhyOct 27 2020, 4:47 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDDEP3b8f33876f84: Replace RawExtrinsicMetadata `id` attribute with `target`..