Page MenuHomeSoftware Heritage
Differential D4335

migrate_extrinsic_metadata: Make pypi_origin_from_filename fix project names when possible using PyPI's API.
ClosedPublic
Actions

Authored by vlorentz on Oct 22 2020, 4:20 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTO474ee72b070b: --amend
Summary

Depends on D4334.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 22 2020, 4:20 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 22 2020, 4:20 PM
vlorentz updated this revision to Diff 15339.Oct 22 2020, 4:23 PM

rebase

swh-public-ci added a comment.Oct 22 2020, 4:25 PM

Build is green

Patch application report for D4335 (id=15337)

Could not rebase; Attempt merge onto aeb72c71d0...

Updating aeb72c71..66f8c9a4
Fast-forward
 swh/storage/migrate_extrinsic_metadata.py          | 68 +++++++++++---------
 .../tests/migrate_extrinsic_metadata/test_pypi.py  | 73 +++++++++++++++++++++-
 2 files changed, 110 insertions(+), 31 deletions(-)
Changes applied before test
commit 66f8c9a49b7e53937e86e3a9ccdf9fe086ff4e15
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 22 16:19:44 2020 +0200

    migrate_extrinsic_metadata: Make pypi_origin_from_filename fix project names when possible using PyPI's API.

commit f75735a7145cd5873653d1f44831b23ea885f3b1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 22 15:19:37 2020 +0200

    migrate_extrinsic_metadata: move pypi_origin_from_filename to its own function.
    
    Instead of bloating handle_row, which is already way too long.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1018/ for more details.

Harbormaster completed remote builds in B16564: Diff 15337.Oct 22 2020, 4:25 PM
swh-public-ci added a comment.Oct 22 2020, 4:34 PM

Build is green

Patch application report for D4335 (id=15339)

Could not rebase; Attempt merge onto aeb72c71d0...

Updating aeb72c71..eb3952f3
Fast-forward
 swh/storage/migrate_extrinsic_metadata.py          | 68 +++++++++++---------
 .../tests/migrate_extrinsic_metadata/test_pypi.py  | 73 +++++++++++++++++++++-
 2 files changed, 110 insertions(+), 31 deletions(-)
Changes applied before test
commit eb3952f3226b9450fe150fb8fda84785fb1868a4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 22 16:19:44 2020 +0200

    migrate_extrinsic_metadata: Make pypi_origin_from_filename fix project names when possible using PyPI's API.

commit b1a3b80f8eff021445489fc1cd7f6d2653632440
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 22 15:19:37 2020 +0200

    migrate_extrinsic_metadata: move pypi_origin_from_filename to its own function.
    
    Instead of bloating handle_row, which is already way too long.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1020/ for more details.

Harbormaster completed remote builds in B16566: Diff 15339.Oct 22 2020, 4:34 PM
vlorentz updated this revision to Diff 15357.Oct 22 2020, 10:35 PM

fix pypi json format

swh-public-ci added a comment.Oct 22 2020, 10:40 PM

Build is green

Patch application report for D4335 (id=15357)

Could not rebase; Attempt merge onto aeb72c71d0...

Updating aeb72c71..474ee72b
Fast-forward
 swh/storage/migrate_extrinsic_metadata.py          | 68 +++++++++++---------
 .../tests/migrate_extrinsic_metadata/test_pypi.py  | 73 +++++++++++++++++++++-
 2 files changed, 110 insertions(+), 31 deletions(-)
Changes applied before test
commit 474ee72b070b1370f5a79503f473f6881ef92755
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 22 22:35:32 2020 +0200

    --amend

commit eb3952f3226b9450fe150fb8fda84785fb1868a4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 22 16:19:44 2020 +0200

    migrate_extrinsic_metadata: Make pypi_origin_from_filename fix project names when possible using PyPI's API.

commit b1a3b80f8eff021445489fc1cd7f6d2653632440
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 22 15:19:37 2020 +0200

    migrate_extrinsic_metadata: move pypi_origin_from_filename to its own function.
    
    Instead of bloating handle_row, which is already way too long.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1021/ for more details.

Harbormaster completed remote builds in B16584: Diff 15357.Oct 22 2020, 10:40 PM
ardumont accepted this revision.Oct 23 2020, 9:25 AM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/storage/migrate_extrinsic_metadata.py
262

is the info entry always there?

This revision is now accepted and ready to land.Oct 23 2020, 9:25 AM
vlorentz added inline comments.Oct 23 2020, 11:11 AM
swh/storage/migrate_extrinsic_metadata.py
262

I haven't found a single case where it's not. And if it happens, I want the script to crash to I can debug it, anyway

Closed by commit rDSTO474ee72b070b: --amend (authored by vlorentz). · Explain WhyOct 23 2020, 11:11 AM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSTO474ee72b070b: --amend.

Revision Contents
Changeset List

PathSize
swh/
storage/
2 lines
tests/
migrate_extrinsic_metadata/
2 lines

Diff 15360

View Options

swh/storage/migrate_extrinsic_metadata.py

Loading...
View Options

swh/storage/tests/migrate_extrinsic_metadata/test_pypi.py

Loading...
About · Developer information · Legal