Page MenuHomeSoftware Heritage

migrate_extrinsic_metadata: move pypi_origin_from_filename to its own function.
ClosedPublic

Authored by vlorentz on Oct 22 2020, 4:17 PM.

Details

Summary

Instead of bloating handle_row, which is already way too long.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D4334 (id=15336)

Rebasing onto aeb72c71d0...

Current branch diff-target is up to date.
Changes applied before test
commit f75735a7145cd5873653d1f44831b23ea885f3b1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 22 15:19:37 2020 +0200

    migrate_extrinsic_metadata: move pypi_origin_from_filename to its own function.
    
    Instead of bloating handle_row, which is already way too long.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1017/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1017/console

Build is green

Patch application report for D4334 (id=15338)

Rebasing onto aeb72c71d0...

Current branch diff-target is up to date.
Changes applied before test
commit b1a3b80f8eff021445489fc1cd7f6d2653632440
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Oct 22 15:19:37 2020 +0200

    migrate_extrinsic_metadata: move pypi_origin_from_filename to its own function.
    
    Instead of bloating handle_row, which is already way too long.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1019/ for more details.

This revision is now accepted and ready to land.Oct 22 2020, 4:44 PM