Differential D4322

scheduler.pytest_plugin: Make scheduler tests faster
ClosedPublic
Actions

Authored by ardumont on Oct 22 2020, 11:59 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSCH2f9e8ec12275: scheduler.pytest_plugin: Make scheduler tests faster

Summary

Reuse the swh.core.db.pytest_plugin factory

|---------+--------------+-------------+----------------|
| machine | before (min) | after (min) | note           |
|---------+--------------+-------------+----------------|
| laptop  |      1:22.73 |    0:45.525 | `time tox`     |
| jenkins |         1:23 |        1:00 | jenkins report |
|---------+--------------+-------------+----------------|

Test Plan

tox

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 22 2020, 11:59 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 22 2020, 11:59 AM

Build is green

Patch application report for D4322 (id=15298)

Rebasing onto 6a4455cea5...

Current branch diff-target is up to date.

Changes applied before test

commit 43e9b160fe0b5dad83545903511b71d0fd2a6740
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 21 16:52:45 2020 +0200

    scheduler.pytest_plugin: Make scheduler tests faster
    
    Reuse the swh.core.db.pytest_plugin factory

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/71/ for more details.

Harbormaster completed remote builds in B16526: Diff 15298.Oct 22 2020, 12:01 PM

ardumont edited the summary of this revision. (Show Details)Oct 22 2020, 12:05 PM

No need for the DUMP_FILES variable

Build is green

Patch application report for D4322 (id=15299)

Rebasing onto 6a4455cea5...

Current branch diff-target is up to date.

Changes applied before test

commit 2f9e8ec12275b185e369ce24eee74c1e3fdf93a3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 21 16:52:45 2020 +0200

    scheduler.pytest_plugin: Make scheduler tests faster
    
    Reuse the swh.core.db.pytest_plugin factory

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/72/ for more details.

Harbormaster completed remote builds in B16527: Diff 15299.Oct 22 2020, 12:09 PM

vlorentz accepted this revision.Oct 22 2020, 12:23 PM

This revision is now accepted and ready to land.Oct 22 2020, 12:23 PM

Closed by commit rDSCH2f9e8ec12275: scheduler.pytest_plugin: Make scheduler tests faster (authored by ardumont). · Explain WhyOct 22 2020, 12:25 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSCH2f9e8ec12275: scheduler.pytest_plugin: Make scheduler tests faster.