Page MenuHomeSoftware Heritage
Differential D4259

deposit-create-chart: Drop obsolete diagram
ClosedPublic
Actions

Authored by ardumont on Oct 14 2020, 3:07 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T2618: Re-draw the flowcharts in swh-deposit documentation using plantuml
Commits
rDDEPd178775952b7: deposit-create-chart: Drop out-of-sync png sequence diagram
Summary

The schema did not change here.

Related to T2618

Test Plan

tox

Diff Detail

Event Timeline

ardumont created this revision.Oct 14 2020, 3:07 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 14 2020, 3:07 PM
ardumont edited the summary of this revision. (Show Details)Oct 14 2020, 3:16 PM
swh-public-ci added a comment.Oct 14 2020, 3:18 PM

Build is green

Patch application report for D4259 (id=15047)

Could not rebase; Attempt merge onto 2f5300e60a...

Updating 2f5300e6..93f795c2
Fast-forward
 docs/images/.gitignore               |   2 +-
 docs/images/deposit-create-chart.png | Bin 53678 -> 0 bytes
 docs/images/deposit-create-chart.svg |  38 +++++
 docs/images/deposit-delete-chart.png | Bin 56979 -> 0 bytes
 docs/images/deposit-delete-chart.svg |  45 +++++
 docs/images/deposit-delete-chart.uml |  29 ++--
 docs/images/deposit-update-chart.png | Bin 61584 -> 0 bytes
 docs/images/deposit-update-chart.svg |  51 ++++++
 docs/images/deposit-update-chart.uml |  20 ++-
 swh/deposit/api/deposit_update.py    |  24 +++
 swh/deposit/cli/admin.py             |  80 +++++----
 swh/deposit/tests/cli/conftest.py    |  12 ++
 swh/deposit/tests/cli/test_admin.py  | 317 +++++++++++++++++++++++++++++++++++
 swh/deposit/tests/cli/test_client.py |   8 +-
 14 files changed, 557 insertions(+), 69 deletions(-)
 delete mode 100644 docs/images/deposit-create-chart.png
 create mode 100644 docs/images/deposit-create-chart.svg
 delete mode 100644 docs/images/deposit-delete-chart.png
 create mode 100644 docs/images/deposit-delete-chart.svg
 delete mode 100644 docs/images/deposit-update-chart.png
 create mode 100644 docs/images/deposit-update-chart.svg
 create mode 100644 swh/deposit/tests/cli/conftest.py
 create mode 100644 swh/deposit/tests/cli/test_admin.py
Changes applied before test
commit 93f795c257941025a7d4fb0f07b4174dfe2ee6b7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 15:06:19 2020 +0200

    deposit-create-chart: Drop png and integrate svg output

commit e40e295ff31e9109b0c137256487d37cb8920230
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 14:55:15 2020 +0200

    deposit-delete-chart: Clarify schema
    
    There is no need for the while loop in there.
    Also the status ready does not exist, it's name 'deposited' status.

commit 1abb2dc63e3a7a7e085b6773c09c13339d80a90c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 14:54:30 2020 +0200

    deposit-update-chart: Clarify schema
    
    There is no need for the while loop in there

commit 34e710d07e88bb18e63a035e594a0bff7675b927
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 12:40:03 2020 +0200

    cli.admin: Add remaining coverage on `swh deposit reschedule` cli

commit 06f437255a222dbd42d788f6f143366ce1b41979
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 11:44:08 2020 +0200

    Add validation step after metadata ingestion of a metadata-only deposit
    
    Related to T2681

commit 51446a11df5cbd6608b282135ea5f2ff30791397
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Oct 13 14:59:50 2020 +0200

    deposit.cli.admin: Add types and coverage on module
    
    This will allow to be more confident when we will refactor the configuration
    part.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/244/ for more details.

Harbormaster completed remote builds in B16274: Diff 15047.Oct 14 2020, 3:18 PM
ardumont edited the summary of this revision. (Show Details)Oct 14 2020, 3:26 PM
ardumont added a task: T2618: Re-draw the flowcharts in swh-deposit documentation using plantuml.
ardumont updated this revision to Diff 15055.Oct 14 2020, 4:31 PM

Rebase

swh-public-ci added a comment.Oct 14 2020, 4:39 PM

Build is green

Patch application report for D4259 (id=15055)

Could not rebase; Attempt merge onto 4bb8a36d7a...

Updating 4bb8a36d..6a9f76b8
Fast-forward
 docs/images/.gitignore               |   2 +-
 docs/images/deposit-create-chart.png | Bin 53678 -> 0 bytes
 docs/images/deposit-create-chart.svg |  38 ++++++++++++++++++++++++++
 docs/images/deposit-delete-chart.png | Bin 56979 -> 0 bytes
 docs/images/deposit-delete-chart.svg |  45 +++++++++++++++++++++++++++++++
 docs/images/deposit-delete-chart.uml |  29 +++++++++-----------
 docs/images/deposit-update-chart.png | Bin 61584 -> 0 bytes
 docs/images/deposit-update-chart.svg |  51 +++++++++++++++++++++++++++++++++++
 docs/images/deposit-update-chart.uml |  20 +++++++-------
 swh/deposit/api/deposit_update.py    |  24 +++++++++++++++++
 10 files changed, 182 insertions(+), 27 deletions(-)
 delete mode 100644 docs/images/deposit-create-chart.png
 create mode 100644 docs/images/deposit-create-chart.svg
 delete mode 100644 docs/images/deposit-delete-chart.png
 create mode 100644 docs/images/deposit-delete-chart.svg
 delete mode 100644 docs/images/deposit-update-chart.png
 create mode 100644 docs/images/deposit-update-chart.svg
Changes applied before test
commit 6a9f76b85b3dc90ec78a14865245c8e97540e8b3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 15:06:19 2020 +0200

    deposit-create-chart: Drop png and integrate svg output

commit 080ced795c5aab33ab77a67ab7b44aafc73d5107
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 14:55:15 2020 +0200

    deposit-delete-chart: Clarify schema
    
    There is no need for the while loop in there.
    Also the status ready does not exist, it's name 'deposited' status.

commit e39814c4af487fca889106b6cfe223b00f7672b7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 14:54:30 2020 +0200

    deposit-update-chart: Clarify schema
    
    There is no need for the while loop in there

commit 92634764f00a0c561523f4fed8073cd9132a5c81
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 11:44:08 2020 +0200

    Add validation step after metadata ingestion of a metadata-only deposit
    
    Related to T2681

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/250/ for more details.

Harbormaster completed remote builds in B16282: Diff 15055.Oct 14 2020, 4:39 PM
vlorentz requested changes to this revision.Oct 15 2020, 10:35 AM
vlorentz added a subscriber: vlorentz.

please don't include the SVG (and fix the "schema" in the commit message)

This revision now requires changes to proceed.Oct 15 2020, 10:35 AM
ardumont updated this revision to Diff 15070.Oct 15 2020, 10:47 AM
  • Drop svg
  • Rework commit message
swh-public-ci added a comment.Oct 15 2020, 10:54 AM

Build is green

Patch application report for D4259 (id=15070)

Could not rebase; Attempt merge onto 4bb8a36d7a...

Updating 4bb8a36d..feda207e
Fast-forward
 docs/images/.gitignore               |   1 +
 docs/images/deposit-create-chart.png | Bin 53678 -> 0 bytes
 docs/images/deposit-delete-chart.png | Bin 56979 -> 0 bytes
 docs/images/deposit-delete-chart.uml |  29 ++++++++++++-----------------
 docs/images/deposit-update-chart.png | Bin 61584 -> 0 bytes
 docs/images/deposit-update-chart.uml |  20 +++++++++++---------
 6 files changed, 24 insertions(+), 26 deletions(-)
 delete mode 100644 docs/images/deposit-create-chart.png
 delete mode 100644 docs/images/deposit-delete-chart.png
 delete mode 100644 docs/images/deposit-update-chart.png
Changes applied before test
commit feda207e124ae25100ec8a7342031efbaede02a5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 15:06:19 2020 +0200

    deposit-create-chart: Drop out-of-sync png sequence diagram

commit 6e894be3749922b9004c1d11c6c19973bcb030d8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 14:54:30 2020 +0200

    deposit-update-chart: Clarify sequence diagram
    
    There is no loop, either the status is partial, either it's not. Removing it
    clarifies the reading.
    
    This also drops the out-of-sync png diagram from the repository.

commit 2576c73a490956b8fd0c9573af504dbfb7ebdadf
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 14:55:15 2020 +0200

    deposit-delete-chart: Clarify schema
    
    There is no loop, either the status is partial, either it's not. Removing it
    clarifies the reading.
    
    This drops the out-of-sync png diagram from the repository. This also renames
    the inexistent `ready` status to the correct 'deposited' status.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/255/ for more details.

Harbormaster completed remote builds in B16296: Diff 15070.Oct 15 2020, 10:54 AM
vlorentz accepted this revision.Oct 15 2020, 11:34 AM
This revision is now accepted and ready to land.Oct 15 2020, 11:34 AM
ardumont updated this revision to Diff 15077.Oct 15 2020, 11:42 AM

Rebase

swh-public-ci added a comment.Oct 15 2020, 11:50 AM

Build is green

Patch application report for D4259 (id=15077)

Could not rebase; Attempt merge onto 4bb8a36d7a...

Updating 4bb8a36d..d1787759
Fast-forward
 docs/images/.gitignore               |   1 +
 docs/images/deposit-create-chart.png | Bin 53678 -> 0 bytes
 docs/images/deposit-delete-chart.png | Bin 56979 -> 0 bytes
 docs/images/deposit-delete-chart.uml |  29 ++++++++++++-----------------
 docs/images/deposit-update-chart.png | Bin 61584 -> 0 bytes
 docs/images/deposit-update-chart.uml |  20 +++++++++++---------
 6 files changed, 24 insertions(+), 26 deletions(-)
 delete mode 100644 docs/images/deposit-create-chart.png
 delete mode 100644 docs/images/deposit-delete-chart.png
 delete mode 100644 docs/images/deposit-update-chart.png
Changes applied before test
commit d178775952b790a3f5c945635b8461a40a919cbb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 15:06:19 2020 +0200

    deposit-create-chart: Drop out-of-sync png sequence diagram

commit 6097f14b7018f2f013a16aca4653698c7182b9ae
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 14:54:30 2020 +0200

    deposit-update-chart: Clarify sequence diagram
    
    There is no loop, either the status is partial, either it's not. Removing it
    clarifies the reading.
    
    This also drops the out-of-sync png diagram from the repository.

commit 4ee6ab25853c1eb3eb9f10763a4c2f48bfd30696
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 14 14:55:15 2020 +0200

    deposit-delete-chart: Clarify sequence diagram
    
    There is no loop, either the status is partial, either it's not. Removing it
    clarifies the reading.
    
    This drops the out-of-sync png diagram from the repository. This also renames
    the inexistent `ready` status to the correct 'deposited' status.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/260/ for more details.

Harbormaster completed remote builds in B16303: Diff 15077.Oct 15 2020, 11:50 AM
ardumont retitled this revision from deposit-create-chart: Drop png and integrate svg output to deposit-create-chart: Drop obsolete diagram.Oct 15 2020, 1:25 PM
Closed by commit rDDEPd178775952b7: deposit-create-chart: Drop out-of-sync png sequence diagram (authored by ardumont). · Explain WhyOct 15 2020, 2:25 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDDEPd178775952b7: deposit-create-chart: Drop out-of-sync png sequence diagram.

Revision Contents
Changeset List

PathSize
docs/
images/

Diff 15070

View Options

docs/images/deposit-create-chart.png

Loading...
About · Developer information · Legal