Page MenuHomeSoftware Heritage
Differential D4183

cli.client: Add types
ClosedPublic
Actions

Authored by ardumont on Oct 7 2020, 3:55 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDDEP7dc727087b99: cli.client: Add types
Test Plan

tox

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16008
Build 24629: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 24628: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.cli.test_client
.tox/py3/lib/python3.7/site-packages/swh/deposit/tests/cli/test_client.py:15: in <module> from swh.deposit.cli import deposit as cli <frozen importlib._bootstrap>:983: in _find_and_load

Event Timeline

ardumont created this revision.Oct 7 2020, 3:55 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 7 2020, 3:55 PM
swh-public-ci added a comment.Oct 7 2020, 3:56 PM

Build has FAILED

Patch application report for D4183 (id=14729)

Could not rebase; Attempt merge onto cd9c04afe6...

Updating cd9c04af..0abc6903
Fast-forward
 conftest.py               |   6 ++-
 pytest.ini                |   2 +-
 swh/deposit/cli/client.py | 105 ++++++++++++++++++++++++----------------------
 3 files changed, 61 insertions(+), 52 deletions(-)
Changes applied before test
commit 0abc69039216b87737f20f9b3780a79d92dffce1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 7 15:56:09 2020 +0200

    cli.client: Add types

commit 98dcf27419726acb0e3cefaf1859346abffa4546
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 7 15:08:29 2020 +0200

    conftest: Declare swh.core pytest_plugin

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/177/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/177/console

Harbormaster failed remote builds in B16006: Diff 14729!Oct 7 2020, 3:56 PM
vlorentz added a subscriber: vlorentz.Oct 7 2020, 4:04 PM

Using a string as type (or from __future__ import annotations) only defers the evaluation, but mypy executes it eventually. So it needs to be available in the same scope as the functions.

Try writing the qualified name?

vlorentz added a comment.Oct 7 2020, 4:08 PM

or, actually: https://forge.softwareheritage.org/source/swh-graph/browse/master/swh/graph/cli.py$18-19

ardumont updated this revision to Diff 14731.Oct 7 2020, 4:23 PM

make mypy happy, thx val

swh-public-ci added a comment.Oct 7 2020, 4:24 PM

Build has FAILED

Patch application report for D4183 (id=14731)

Could not rebase; Attempt merge onto cd9c04afe6...

Updating cd9c04af..8665a162
Fast-forward
 conftest.py               |   6 ++-
 pytest.ini                |   2 +-
 swh/deposit/cli/client.py | 109 +++++++++++++++++++++++++---------------------
 3 files changed, 65 insertions(+), 52 deletions(-)
Changes applied before test
commit 8665a162b68199bde41eeb618e578526b5b3d23f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 7 15:56:09 2020 +0200

    cli.client: Add types

commit 98dcf27419726acb0e3cefaf1859346abffa4546
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 7 15:08:29 2020 +0200

    conftest: Declare swh.core pytest_plugin

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/178/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/178/console

Harbormaster failed remote builds in B16008: Diff 14731!Oct 7 2020, 4:24 PM
ardumont updated this revision to Diff 14732.Oct 7 2020, 4:27 PM

and now make tox happy

ardumont edited the summary of this revision. (Show Details)Oct 7 2020, 4:27 PM
swh-public-ci added a comment.Oct 7 2020, 4:29 PM

Build is green

Patch application report for D4183 (id=14732)

Could not rebase; Attempt merge onto cd9c04afe6...

Updating cd9c04af..7dc72708
Fast-forward
 conftest.py               |   6 ++-
 pytest.ini                |   2 +-
 swh/deposit/cli/client.py | 109 +++++++++++++++++++++++++---------------------
 3 files changed, 65 insertions(+), 52 deletions(-)
Changes applied before test
commit 7dc727087b99159335e3daf90b5a1c4180ebf5e6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 7 15:56:09 2020 +0200

    cli.client: Add types

commit 98dcf27419726acb0e3cefaf1859346abffa4546
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 7 15:08:29 2020 +0200

    conftest: Declare swh.core pytest_plugin

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/179/ for more details.

Harbormaster completed remote builds in B16009: Diff 14732.Oct 7 2020, 4:30 PM
vlorentz accepted this revision.Oct 8 2020, 5:59 PM
vlorentz added inline comments.
swh/deposit/cli/client.py
103

doesn't need to be a string anymore

119

same

This revision is now accepted and ready to land.Oct 8 2020, 5:59 PM
vlorentz added a comment.Oct 8 2020, 5:59 PM

(you'll have to add from __future__ import annotations though)

ardumont added inline comments.Oct 8 2020, 6:02 PM
swh/deposit/cli/client.py
103

i thought as much but it failed without it...
see one iteration before that last diff update...

ardumont mentioned this in D4204: test_client: Migrate nominal collection scenario to use requests_mock_datadir.Oct 8 2020, 6:43 PM
vlorentz added inline comments.Oct 8 2020, 7:02 PM
swh/deposit/cli/client.py
103

see my other comment

ardumont added inline comments.Oct 8 2020, 7:41 PM
swh/deposit/cli/client.py
103

oh thanks, i did not notice it...
I'll fix in another diff (i built on this one and now, lazyness hit me ;)

Closed by commit rDDEP7dc727087b99: cli.client: Add types (authored by ardumont). · Explain WhyOct 8 2020, 7:42 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDDEP7dc727087b99: cli.client: Add types.
ardumont added inline comments.Oct 8 2020, 7:44 PM
swh/deposit/cli/client.py
103

D4208

Revision Contents
Changeset List

PathSize
swh/
deposit/
cli/
109 lines

Diff 14731

View Options

swh/deposit/cli/client.py

Loading...
About · Developer information · Legal