Differential D4208

cli.client: Declare directly the plain type instead of the string
ClosedPublic
Actions

Authored by ardumont on Oct 8 2020, 7:44 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDDEP6b7d5336f701: cli.client: Declare directly the plain type instead of the string

Summary

Depends on D4207

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 8 2020, 7:44 PM

ardumont mentioned this in D4183: cli.client: Add types.Oct 8 2020, 7:44 PM

Build is green

Patch application report for D4208 (id=14841)

Could not rebase; Attempt merge onto 7dc727087b...

Updating 7dc72708..460b32ae
Fast-forward
 swh/deposit/cli/client.py                          |   6 +-
 swh/deposit/tests/cli/test_client.py               | 157 +++++++++++----------
 swh/deposit/tests/conftest.py                      |  14 ++
 .../data/https_deposit.swh.test/1_servicedocument  |  26 ++++
 .../tests/data/https_deposit.swh.test/1_test       |  19 +++
 swh/deposit/tests/loader/conftest.py               |  14 --
 6 files changed, 144 insertions(+), 92 deletions(-)
 create mode 100644 swh/deposit/tests/data/https_deposit.swh.test/1_servicedocument
 create mode 100644 swh/deposit/tests/data/https_deposit.swh.test/1_test

Changes applied before test

commit 460b32ae20452f4975fcf52b4a44172fb00891a8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 8 19:44:41 2020 +0200

    cli.client: Declare directly the plain type instead of the string

commit 5a2ce1316d9df69aabf16660cc092578f9ab117d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 8 19:32:30 2020 +0200

    test_client: Migrate slug generation scenario to use requests_mock_datadir
    
    instead of mock

commit b035c9593b6c5ccef1d8d96d15f9ef5b26d7e0d0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 8 19:22:46 2020 +0200

    test_client: Migrate metadata validation scenario to use requests_mock_datadir
    
    instead of mock

commit ff8457630b548728349aae18f5cbc223c942ef02
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 8 19:08:34 2020 +0200

    test_client: Migrate single deposit scenario to use requests_mock_datadir

commit 2b4ad2cfe1927507b0e182ec3f15a3a733ad5ae2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 8 18:41:51 2020 +0200

    test_client: Migrate collection ok test scenario to use requests_mock_datadir
    
    instead of mock

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/185/ for more details.

Harbormaster completed remote builds in B16079: Diff 14841.Oct 8 2020, 7:47 PM

vlorentz accepted this revision.Oct 9 2020, 8:52 AM

This revision is now accepted and ready to land.Oct 9 2020, 8:52 AM

Rebase

Build is green

Patch application report for D4208 (id=14852)

Rebasing onto 7dc727087b...

Current branch diff-target is up to date.

Changes applied before test

commit 6b7d5336f7018c526e310a5b1af40dc2be40010d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 8 19:44:41 2020 +0200

    cli.client: Declare directly the plain type instead of the string

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/186/ for more details.

Harbormaster completed remote builds in B16090: Diff 14852.Oct 9 2020, 11:57 AM

Closed by commit rDDEP6b7d5336f701: cli.client: Declare directly the plain type instead of the string (authored by ardumont). · Explain WhyOct 9 2020, 11:59 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEP6b7d5336f701: cli.client: Declare directly the plain type instead of the string.