Disable network profile for vagrant.
ClosedPublic
Actions

Authored by olasd on Oct 6 2020, 7:04 PM.

Details

Reviewers

ardumont
vsellier

Maniphest Tasks

T2606: Test puppet configuration in a local vagrant environment

Commits

rSPSITE2defd02d796d: Add a `manage_interfaces` variable to guard /etc/network/interfaces management

Summary

This allows us to get rid of the vagant-specific hiera override completely.

Supersedes D4147

Test Plan

run vagrant with some changes (to be referenced)

Diff Detail

Repository

rSPSITE puppet-swh-site

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Oct 6 2020, 7:04 PM

Harbormaster completed remote builds in B15953: Diff 14676.Oct 6 2020, 7:04 PM

olasd mentioned this in D4168: Update Vagrantfile to match recent changes to swh-site.Oct 6 2020, 7:05 PM

\m/

(about what i just said in the other diff) there you go ;)

This revision is now accepted and ready to land.Oct 6 2020, 7:24 PM

WDYT to add a variable like profile::network::[activated|managed|whatever] to activate or not the network profile application ? It would avoid to introduce some vagrant specifics in the manifests

ardumont added a task: T2606: Test puppet configuration in a local vagrant environment.Oct 6 2020, 7:27 PM

In D4167#103274, @vsellier wrote:

WDYT to add a variable like profile::network::[activated|managed|whatever] to activate or not the network profile application ? It would avoid to introduce some vagrant specifics in the manifests

Yeah, that would probably be more sensible. I can see how other cloud-inited platforms (like azure) may want to disable /etc/network/interfaces management too. I'll do that.

Implement this change with a new boolean variable

Harbormaster completed remote builds in B16056: Diff 14790.Oct 8 2020, 2:26 PM

vsellier accepted this revision.Oct 8 2020, 3:50 PM

Closed by commit rSPSITE2defd02d796d: Add a `manage_interfaces` variable to guard /etc/network/interfaces management (authored by olasd). · Explain WhyOct 8 2020, 5:58 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rSPSITE2defd02d796d: Add a `manage_interfaces` variable to guard /etc/network/interfaces management.