Differential D4158

mimetype: use ContentMimetypeRow in the storage interface instead of dicts.
ClosedPublic
Actions

Authored by vlorentz on Oct 6 2020, 3:44 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2652: Make the indexer-storage interface use attr classes instead of dicts

Commits

rDCIDXc3caf3008300: mimetype: use ContentMimetypeRow in the storage interface instead of dicts.

Summary

This temporarily adds mess in the generic tests to support both rows and dicts,
but I'll remove it once I migrated all endpoints.

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 6 2020, 3:44 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 6 2020, 3:44 PM

vlorentz added a child revision: D4159: Make base indexers generic, with the result of index() as their type parameter..Oct 6 2020, 3:44 PM

Build is green

Patch application report for D4158 (id=14661)

Rebasing onto 51b10e891d...

Current branch diff-target is up to date.

Changes applied before test

commit c3caf300830030f0cd1b3002d715e430582db8f1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 6 15:35:39 2020 +0200

    mimetype: use ContentMimetypeRow in the storage interface instead of dicts.
    
    This temporarily adds mess in the generic tests to support both rows and dicts,
    but I'll remove it once I migrated all endpoints.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/67/ for more details.

Harbormaster completed remote builds in B15938: Diff 14661.Oct 6 2020, 3:45 PM