HomeSoftware Heritage
Diffusion Metadata indexer 51b10e891d33

Fix inconsistencies in exception handling between the base indexers.
51b10e891d33
Actions

Description

Fix inconsistencies in exception handling between the base indexers.

And fix the incorrect test test_generate_content_get, which was
passing for the wrong reasons.

Details

Provenance
vlorentzAuthored on Oct 6 2020, 1:30 PM
vlorentzPushed on Oct 6 2020, 2:57 PM
Differential Revision
D4152: Fix inconsistencies in exception handling between the base indexers.
Parents
rDCIDX6535444922eb: test_generate_content_get_no_result: Pass a multiple of 2 as number of…
Branches
Unknown
Tags
Unknown
Build Status
Buildable 15936
Build 24522: test-and-buildJenkins console · Jenkins

Event Timeline

vlorentz added an edge: D4152: Fix inconsistencies in exception handling between the base indexers..Oct 6 2020, 2:57 PM
vlorentz committed rDCIDX51b10e891d33: Fix inconsistencies in exception handling between the base indexers. (authored by vlorentz).Oct 6 2020, 2:01 PM
Harbormaster completed building B15936: rDCIDX51b10e891d33: Fix inconsistencies in exception handling between the base indexers..Oct 6 2020, 3:02 PM
swh-public-ci mentioned this in D4158: mimetype: use ContentMimetypeRow in the storage interface instead of dicts..Oct 6 2020, 3:45 PM
swh-public-ci mentioned this in D4159: Make base indexers generic, with the result of index() as their type parameter..
swh-public-ci mentioned this in D4169: tests: Enable type-checking on storage test functions..Oct 7 2020, 10:03 AM
swh-public-ci mentioned this in D4170: indexer.storage: Change return type annotation from Iterator to Iterable..Oct 7 2020, 10:48 AM
swh-public-ci mentioned this in D4171: indexer.storage: Update docstrings of mimetype-related endpoints..Oct 7 2020, 10:50 AM
swh-public-ci mentioned this in D4172: base indexers: add type annotation for self.{storage,idx_storage}..Oct 7 2020, 10:56 AM
swh-public-ci mentioned this in D4173: license: use ContentLicenseRow in the storage interface instead of dicts..Oct 7 2020, 11:10 AM
swh-public-ci mentioned this in D4174: indexer.storage: Change return types from Iterable to List.Oct 7 2020, 11:27 AM
swh-public-ci mentioned this in D4176: use ContentLanguageRow in the storage interface instead of dicts..Oct 7 2020, 12:45 PM
swh-public-ci mentioned this in D4177: use ContentCtagsRow in the storage interface instead of dicts..Oct 7 2020, 1:42 PM
swh-public-ci mentioned this in D4180: use ContentMetadataRow in the storage interface instead of dicts..Oct 7 2020, 3:12 PM
swh-public-ci mentioned this in D4184: use RevisionIntrinsicMetadataRow in the storage interface instead of dicts..Oct 7 2020, 4:03 PM
swh-public-ci mentioned this in D4187: use OriginIntrinsicMetadataRow in the storage interface instead of dicts..Oct 7 2020, 5:23 PM
swh-public-ci mentioned this in D4188: tests: Clean up compatibility code with endpoints that return dicts..Oct 7 2020, 5:31 PM
swh-public-ci mentioned this in D4189: Properly define the type of index() methods of indexers..Oct 7 2020, 5:52 PM

Changes (3)

PathSize
swh/
indexer/
tests/

rDCIDX51b10e891d33

View Options

swh/indexer/indexer.py

Loading...
View Options

swh/indexer/tests/test_indexer.py

Loading...
View Options

swh/indexer/tests/utils.py

Loading...
About · Developer information · Legal