debian: Fix mypy error by asserting ChangeBlock.package is not None.
ClosedPublic
Actions

Authored by vlorentz on Oct 5 2020, 2:48 PM.

Details

Reviewers

anlambert
ardumont

Group Reviewers

Reviewers

Commits

rDLDBASE7d3d8ffa304d: debian: Fix mypy error by asserting ChangeBlock.package is not None.

Summary

Under some conditions, mypy can detect it is declared as Optional[str].

Fixes jenkins build [1]

[1] https://jenkins.softwareheritage.org/job/DLDBASE/job/tests/1139/console

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 5 2020, 2:48 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 5 2020, 2:48 PM

Build is green

Patch application report for D4143 (id=14608)

Rebasing onto 64f2361c85...

Current branch diff-target is up to date.

Changes applied before test

commit 7d3d8ffa304d9674cf2f3253d3c9df543135ca10
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Oct 5 14:47:24 2020 +0200

    debian: Fix mypy error by asserting ChangeBlock.package is not None.
    
    Under some conditions, mypy can detect it is declared as Optional[str].

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/325/ for more details.

Harbormaster completed remote builds in B15889: Diff 14608.Oct 5 2020, 2:50 PM

vlorentz added a child revision: D4142: npm: write metadata on revisions instead of snapshots..Oct 5 2020, 2:50 PM

anlambert accepted this revision.Oct 5 2020, 2:52 PM

This revision is now accepted and ready to land.Oct 5 2020, 2:52 PM

ardumont accepted this revision.Oct 5 2020, 9:16 PM

ardumont edited the summary of this revision. (Show Details)

Closed by commit rDLDBASE7d3d8ffa304d: debian: Fix mypy error by asserting ChangeBlock.package is not None. (authored by vlorentz). · Explain WhyOct 6 2020, 9:54 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDBASE7d3d8ffa304d: debian: Fix mypy error by asserting ChangeBlock.package is not None..